Hello build bot (Jenkins), Zheng Bao,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66784
to look at the new patch set (#2).
Change subject: amdfwtool: Resequence some steps for the loop for combo ......................................................................
amdfwtool: Resequence some steps for the loop for combo
To support combo, there will be a loop to iterate. Some steps will be padded into a loop. Move them together so it is easier to review and write code later.
Each entry of combo has its own fw.cfg. Processing the fw.cfg and other statements relied on it should be put into the loop. Setting the EFS table should be moved downward outside of the loop. Address mode will not be available before processing fw.cfg. Set it as phyisical address mode at beginning for old family SOC.
The loop will be from L2553 to L2676.
TEST=binary identical test on amd/birman amd/majolica amd/gardenia amd/mandolin pcengines/apu2
Change-Id: Ie4543fe18d77bfbaf9d34914e6f27b5ba8791d28 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 74 insertions(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/66784/2