Hello Felix Singer, Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48410
to review the following change.
Change subject: cpu/intel/model_206ax: Add more CPU steppings ......................................................................
cpu/intel/model_206ax: Add more CPU steppings
The Sandy Bridge steppings appear in the BWG, and Ivy Bridge steppings appear in reference code. Add them for the sake of completeness.
Change-Id: I7d17cdd04a771ca319c908fc757f868e95ea7944 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/intel/model_206ax/model_206ax.h M src/northbridge/intel/sandybridge/raminit_common.h 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/48410/1
diff --git a/src/cpu/intel/model_206ax/model_206ax.h b/src/cpu/intel/model_206ax/model_206ax.h index 195ef15..04e4639 100644 --- a/src/cpu/intel/model_206ax/model_206ax.h +++ b/src/cpu/intel/model_206ax/model_206ax.h @@ -7,6 +7,8 @@ #include <stdint.h>
/* SandyBridge CPU stepping */ +#define SNB_STEP_B2 2 +#define SNB_STEP_C0 3 #define SNB_STEP_D0 5 /* Also J0 */ #define SNB_STEP_D1 6 #define SNB_STEP_D2 7 /* Also J1/Q0 */ @@ -17,6 +19,8 @@ #define IVB_STEP_C0 4 #define IVB_STEP_K0 5 #define IVB_STEP_D0 6 +#define IVB_STEP_E0 8 +#define IVB_STEP_E1 9
#define IS_SANDY_CPU(x) ((x & 0xffff0) == 0x206a0) #define IS_SANDY_CPU_C(x) ((x & 0xf) == 4) diff --git a/src/northbridge/intel/sandybridge/raminit_common.h b/src/northbridge/intel/sandybridge/raminit_common.h index 4499123..3f094d0 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.h +++ b/src/northbridge/intel/sandybridge/raminit_common.h @@ -3,6 +3,7 @@ #ifndef RAMINIT_COMMON_H #define RAMINIT_COMMON_H
+#include <cpu/intel/model_206ax/model_206ax.h> #include <stdint.h>
#define BASEFREQ 133
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48410 )
Change subject: cpu/intel/model_206ax: Add more CPU steppings ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48410 )
Change subject: cpu/intel/model_206ax: Add more CPU steppings ......................................................................
cpu/intel/model_206ax: Add more CPU steppings
The Sandy Bridge steppings appear in the BWG, and Ivy Bridge steppings appear in reference code. Add them for the sake of completeness.
Change-Id: I7d17cdd04a771ca319c908fc757f868e95ea7944 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48410 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/cpu/intel/model_206ax/model_206ax.h M src/northbridge/intel/sandybridge/raminit_common.h 2 files changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/cpu/intel/model_206ax/model_206ax.h b/src/cpu/intel/model_206ax/model_206ax.h index 195ef15..04e4639 100644 --- a/src/cpu/intel/model_206ax/model_206ax.h +++ b/src/cpu/intel/model_206ax/model_206ax.h @@ -7,6 +7,8 @@ #include <stdint.h>
/* SandyBridge CPU stepping */ +#define SNB_STEP_B2 2 +#define SNB_STEP_C0 3 #define SNB_STEP_D0 5 /* Also J0 */ #define SNB_STEP_D1 6 #define SNB_STEP_D2 7 /* Also J1/Q0 */ @@ -17,6 +19,8 @@ #define IVB_STEP_C0 4 #define IVB_STEP_K0 5 #define IVB_STEP_D0 6 +#define IVB_STEP_E0 8 +#define IVB_STEP_E1 9
#define IS_SANDY_CPU(x) ((x & 0xffff0) == 0x206a0) #define IS_SANDY_CPU_C(x) ((x & 0xf) == 4) diff --git a/src/northbridge/intel/sandybridge/raminit_common.h b/src/northbridge/intel/sandybridge/raminit_common.h index 4499123..3f094d0 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.h +++ b/src/northbridge/intel/sandybridge/raminit_common.h @@ -3,6 +3,7 @@ #ifndef RAMINIT_COMMON_H #define RAMINIT_COMMON_H
+#include <cpu/intel/model_206ax/model_206ax.h> #include <stdint.h>
#define BASEFREQ 133
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Patrick Rudolph (Code Review)