Change in coreboot[master]: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support

[John Su (Code Review)]

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

mb/google/octopus/variants/fleex: Add G2Touch touchscreen support

BUG=b:167297664
TEST=build fleex, and check touchscreen can work

Signed-off-by: John Su 
Change-Id: I910681c258ff5487830e795a8bd08c66be69b1d4
---
M src/mainboard/google/octopus/variants/fleex/overridetree.cb
1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/44980/1

diff --git a/src/mainboard/google/octopus/variants/fleex/overridetree.cb b/src/mainboard/google/octopus/variants/fleex/overridetree.cb
index 1d1a67a..0b81752 100644
--- a/src/mainboard/google/octopus/variants/fleex/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/fleex/overridetree.cb
@@ -156,6 +156,20 @@
    			register "hid_desc_reg_offset" = "0x20"
    			device i2c 2c on end
    		end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""GTCH7503""
+				register "generic.desc" = ""G2TOUCH Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
+				register "generic.reset_delay_ms" = "50"
+				register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)"
+				register "generic.enable_delay_ms" = "1"
+				register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
+				register "hid_desc_reg_offset" = "0x01"
+				device i2c 40 on end
+			end
    	end	# - I2C 7
    end

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

Patch Set 1:

This change is ready for review.

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

Patch Set 1: Code-Review+1

This change is ready for review.

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

Patch Set 1: Code-Review+2

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

Patch Set 1:

Vendor verified power sequence PASS.

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

Patch Set 1:

Hi Google

Could you help to review this CL?

[Henry Sun (Code Review)]

Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

Patch Set 1: Code-Review+1

[John Su (Code Review)]

Hello Frank Wu, build bot (Jenkins), Henry Sun, Justin TerAvest, Marco Chen, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44980

to look at the new patch set (#2).

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

mb/google/octopus/variants/fleex: Add G2Touch touchscreen support

BUG=b:167297664
BRANCH=octopus
TEST=build fleex, and check touchscreen can work

Signed-off-by: John Su 
Change-Id: I910681c258ff5487830e795a8bd08c66be69b1d4
---
M src/mainboard/google/octopus/variants/fleex/overridetree.cb
1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/44980/2

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

Patch Set 2: Code-Review+1

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

Patch Set 2:

Hi Google
Could you help cherry-pick this CL to gerrit-ToT?
Thanks.

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

Patch Set 2: Code-Review+2

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

mb/google/octopus/variants/fleex: Add G2Touch touchscreen support

BUG=b:167297664
BRANCH=octopus
TEST=build fleex, and check touchscreen can work

Signed-off-by: John Su 
Change-Id: I910681c258ff5487830e795a8bd08c66be69b1d4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44980
Reviewed-by: Justin TerAvest 
Reviewed-by: Justin TerAvest 
Reviewed-by: Marco Chen 
Reviewed-by: EricR Lai 
Reviewed-by: Henry Sun 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/octopus/variants/fleex/overridetree.cb
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Justin TerAvest: Looks good to me, approved
  Justin TerAvest: Looks good to me, but someone else must approve
  Marco Chen: Looks good to me, approved
  John Su: Looks good to me, but someone else must approve
  EricR Lai: Looks good to me, approved
  Henry Sun: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/octopus/variants/fleex/overridetree.cb b/src/mainboard/google/octopus/variants/fleex/overridetree.cb
index 1d1a67a..0b81752 100644
--- a/src/mainboard/google/octopus/variants/fleex/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/fleex/overridetree.cb
@@ -156,6 +156,20 @@
    			register "hid_desc_reg_offset" = "0x20"
    			device i2c 2c on end
    		end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""GTCH7503""
+				register "generic.desc" = ""G2TOUCH Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
+				register "generic.reset_delay_ms" = "50"
+				register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)"
+				register "generic.enable_delay_ms" = "1"
+				register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
+				register "hid_desc_reg_offset" = "0x01"
+				device i2c 40 on end
+			end
    	end	# - I2C 7
    end

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44980 )

Change subject: mb/google/octopus/variants/fleex: Add G2Touch touchscreen support
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19184
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19183
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19182
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19181
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19180
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19188
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19187
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19186
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19185

Please note: This test is under development and might not be accurate at all!