Attention is currently required from: Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86110?usp=email )
Change subject: soc/mediatek/mt8196: Add mtk_fsp_romstage version v1.0 ......................................................................
Patch Set 2:
(5 comments)
File soc/mediatek/mt8196/README.md:
https://review.coreboot.org/c/blobs/+/86110/comment/e5d2f019_d6da94f5?usp=em... : PS2, Line 240: `mtk_fsp_romstage.elf` is an ELF format file Remove this sentence, as it's trivial from the file name.
https://review.coreboot.org/c/blobs/+/86110/comment/d8ae653e_d9d7af76?usp=em... : PS2, Line 241: include includes
https://review.coreboot.org/c/blobs/+/86110/comment/4eb47dbb_02adc169?usp=em... : PS2, Line 244: This is a markdown file, so we don't need to align the text like this. Just 2 spaces (to align with "power switch").
https://review.coreboot.org/c/blobs/+/86110/comment/35bd1cc1_b1abf04f?usp=em... : PS2, Line 245: such as the CVCC (Constant Voltage, Constant Current) : voltage of SRAM.
such as Constant Voltage, Constant Current of SRAM.
Note the line length.
https://review.coreboot.org/c/blobs/+/86110/comment/03281afa_af622bc5?usp=em... : PS2, Line 256: -1 non-zero