Change in coreboot[master]: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common`

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Paul Menzel (Code Review)

23 Jul 2020 23 Jul '20

5:08 p.m.

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43759 )

Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................

Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common`

Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Makefile.inc M src/lib/gnat/Makefile.inc 2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/43759/1

diff --git a/Makefile.inc b/Makefile.inc index 89bb3e4..ca9f10e 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -439,6 +439,7 @@ ADAFLAGS_common += -Wstrict-aliasing -Wshadow ADAFLAGS_common += -fno-common -fomit-frame-pointer ADAFLAGS_common += -ffunction-sections -fdata-sections +ADAFLAGS_common += -fno-pie # Ada warning options: # # a Activate most optional warnings. diff --git a/src/lib/gnat/Makefile.inc b/src/lib/gnat/Makefile.inc index e740564..065ba71 100644 --- a/src/lib/gnat/Makefile.inc +++ b/src/lib/gnat/Makefile.inc @@ -13,6 +13,7 @@ -I$$(src)/lib/gnat/ \ $$(GCC_ADAFLAGS_$(1)) \ -Werror \ + -fno-pie \

libgnat-$(1)-y += a-unccon.ads libgnat-$(1)-y += ada.ads

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Paul Menzel (Code Review)

14 Nov 14 Nov

7:17 p.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43759

to look at the new patch set (#3).

Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................

Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common`

E: Invalid reloc type: 10 E: Unable to create rmodule from 'build/cbfs/fallback/ramstage.debug'.

Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Makefile.inc M src/lib/gnat/Makefile.inc 2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/43759/3

Paul Menzel (Code Review)

10 Jan 10 Jan

5:33 p.m.

Hello build bot (Jenkins), Martin Roth - Personal,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43759

to look at the new patch set (#11).

Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................

Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common`

Building libgfxinit with Debian’s toolchain, latest test with *gnat-11* 11.2.0-13 from Debian sid/unstable, the build fails with the error below.

E: Invalid reloc type: 10 E: Unable to create rmodule from 'build/cbfs/fallback/ramstage.debug'.

Debian’s toolchain is built without PIE:

$ grep pie /usr/share/lintian/overrides/gnat-11 gnat-11 binary: hardening-no-pie

So, explicitly pass `-fno-pie` to `ADAFLAGS_common` to be independent from how the toolchain was built.

TEST=*gnat* 11.2.0-13 successfully. builds purism/librem_cnl/variants/librem_mini with libgfxint. Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Makefile.inc M src/lib/gnat/Makefile.inc 2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/43759/11

Angel Pons (Code Review)

13 Jan 13 Jan

1:50 p.m.

Attention is currently required from: Nico Huber, Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43759 )

Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................

Patch Set 11: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Gerrit-Change-Number: 43759 Gerrit-PatchSet: 11 Gerrit-Owner: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Comment-Date: Thu, 13 Jan 2022 13:50:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

17 Jan 17 Jan

12:48 p.m.

Attention is currently required from: Paul Menzel. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43759 )

Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................

Patch Set 11: Code-Review+1

(1 comment)

Patchset:

PS11: Please test if this changes binaries built with our reference toolchain.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Gerrit-Change-Number: 43759 Gerrit-PatchSet: 11 Gerrit-Owner: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Comment-Date: Mon, 17 Jan 2022 12:48:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:25 p.m.

Attention is currently required from: Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43759 )

Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................

Patch Set 11:

(1 comment)

Patchset:

PS11:

...

Please test if this changes binaries built with our reference toolchain.

The binary does not change.

$ make crossgcc-i386 $ git describe 4.15-1078-g50251400d2 $ more defconfig CONFIG_VENDOR_PURISM=y CONFIG_CBFS_SIZE=0xA00000 CONFIG_CONSOLE_CBMEM_BUFFER_SIZE=0x20000 CONFIG_BOARD_PURISM_LIBREM_MINI_V2=y CONFIG_UART_PCI_ADDR=0x0 CONFIG_SUBSYSTEM_VENDOR_ID=0x0000 CONFIG_SUBSYSTEM_DEVICE_ID=0x0000 CONFIG_PAYLOAD_NONE=y $ make BUILD_TIMELESS=1 […] $ md5sum build/coreboot.rom 6aea50216952865c61f8bef2c7dd768b build/coreboot.rom $ git fetch https://review.coreboot.org/coreboot refs/changes/59/43759/11 && git cherry-pick FETCH_HEAD $ make BUILD_TIMELESS=1 […] $ md5sum build/coreboot.rom 6aea50216952865c61f8bef2c7dd768b build/coreboot.rom

-- To view, visit https://review.coreboot.org/c/coreboot/+/43759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Gerrit-Change-Number: 43759 Gerrit-PatchSet: 11 Gerrit-Owner: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Mon, 17 Jan 2022 21:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Nico Huber (Code Review)

18 Jan 18 Jan

11:15 a.m.

Attention is currently required from: Paul Menzel. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43759 )

Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................

Patch Set 11:

(1 comment)

Patchset:

PS11:

...

The binary does not change. […]

Thanks. Please mention these results in the commit message.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Gerrit-Change-Number: 43759 Gerrit-PatchSet: 11 Gerrit-Owner: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Comment-Date: Tue, 18 Jan 2022 11:15:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: comment

Paul Menzel (Code Review)

11:45 a.m.

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), Nico Huber, Martin Roth, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43759

to look at the new patch set (#12).

Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................

Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common`

Building libgfxinit with Debian’s toolchain – latest test with *gnat-11* 11.2.0-13 from Debian sid/unstable – the build fails with the error below.

E: Invalid reloc type: 10 E: Unable to create rmodule from 'build/cbfs/fallback/ramstage.debug'.

Debian’s toolchain is built without enabling PIE by default.

So, explicitly pass `-fno-pie` to `ADAFLAGS_common` to be independent from how the toolchain was built.

TEST=*gnat* 11.2.0-13 successfully. builds purism/librem_cnl/variants/librem_mini with libgfxint.

With the coreboot toolchain `make BUILD_TIMELESS=1` produces the same `build/coreboot.rom` for `BOARD_PURISM_LIBREM_MINI_V2=y` on top of commit 50251400d2 (sb/intel/common/firmware: Reword me_cleaner warning) with and without the change. Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Makefile.inc M src/lib/gnat/Makefile.inc 2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/43759/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/43759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Gerrit-Change-Number: 43759 Gerrit-PatchSet: 12 Gerrit-Owner: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

11:45 a.m.

Attention is currently required from: Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43759 )

Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................

Patch Set 11:

(1 comment)

Patchset:

PS11:

...

Thanks. Please mention these results in the commit message.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Gerrit-Change-Number: 43759 Gerrit-PatchSet: 11 Gerrit-Owner: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Tue, 18 Jan 2022 11:45:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: comment

Nico Huber (Code Review)

23 Jan 23 Jan

6:55 p.m.

Attention is currently required from: Paul Menzel. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43759 )

Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................

Patch Set 12: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Gerrit-Change-Number: 43759 Gerrit-PatchSet: 12 Gerrit-Owner: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin L. Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Comment-Date: Sun, 23 Jan 2022 18:55:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

6:55 p.m.

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43759 )

Change subject: Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common` ......................................................................

Makefile.inc: Add `-fno-pie` to `ADAFLAGS_common`

Building libgfxinit with Debian’s toolchain – latest test with *gnat-11* 11.2.0-13 from Debian sid/unstable – the build fails with the error below.

E: Invalid reloc type: 10 E: Unable to create rmodule from 'build/cbfs/fallback/ramstage.debug'.

Debian’s toolchain is built without enabling PIE by default.

So, explicitly pass `-fno-pie` to `ADAFLAGS_common` to be independent from how the toolchain was built.

TEST=*gnat* 11.2.0-13 successfully. builds purism/librem_cnl/variants/librem_mini with libgfxint.

With the coreboot toolchain `make BUILD_TIMELESS=1` produces the same `build/coreboot.rom` for `BOARD_PURISM_LIBREM_MINI_V2=y` on top of commit 50251400d2 (sb/intel/common/firmware: Reword me_cleaner warning) with and without the change. Change-Id: I6661937906d95c130c6099f598d61b21e958fd85 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/43759 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M Makefile.inc M src/lib/gnat/Makefile.inc 2 files changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved

diff --git a/Makefile.inc b/Makefile.inc index cc7317d..1c76a91 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -444,6 +444,7 @@ ADAFLAGS_common += -Wstrict-aliasing -Wshadow ADAFLAGS_common += -fno-common -fomit-frame-pointer ADAFLAGS_common += -ffunction-sections -fdata-sections +ADAFLAGS_common += -fno-pie # Ada warning options: # # a Activate most optional warnings. diff --git a/src/lib/gnat/Makefile.inc b/src/lib/gnat/Makefile.inc index e740564..065ba71 100644 --- a/src/lib/gnat/Makefile.inc +++ b/src/lib/gnat/Makefile.inc @@ -13,6 +13,7 @@ -I$$(src)/lib/gnat/ \ $$(GCC_ADAFLAGS_$(1)) \ -Werror \ + -fno-pie \

libgnat-$(1)-y += a-unccon.ads libgnat-$(1)-y += ada.ads

1040

days inactive

1589

days old

coreboot-gerrit@coreboot.org

10 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)