Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37021 )
Change subject: util/release: always remove temporary files ......................................................................
util/release: always remove temporary files
Change-Id: I8e6ff5bc72618e782ed472878bd6ea294be1b5ca Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/release/genrelnotes 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/37021/1
diff --git a/util/release/genrelnotes b/util/release/genrelnotes index 718c6f8..a41e563 100755 --- a/util/release/genrelnotes +++ b/util/release/genrelnotes @@ -426,8 +426,8 @@ git log --pretty=%an "${NEW_GIT_VERSION}" 2>/dev/null | \ sort | uniq > "$after_names" && \ grep -Fxv -c -f "$before_names" "$after_names") -NEW_AUTHOR_LIST=$( grep -Fxv -f "$before_names" "$after_names" && \ - rm "$before_names" "$after_names") +NEW_AUTHOR_LIST=$( grep -Fxv -f "$before_names" "$after_names") +rm -f "$before_names" "$after_names" { printf -- "- Total commits: %s\n" "$TOTAL_COMMITS" printf -- "- Total authors: %s\n" \
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37021 )
Change subject: util/release: always remove temporary files ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37021 )
Change subject: util/release: always remove temporary files ......................................................................
util/release: always remove temporary files
Change-Id: I8e6ff5bc72618e782ed472878bd6ea294be1b5ca Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37021 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/release/genrelnotes 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
diff --git a/util/release/genrelnotes b/util/release/genrelnotes index 25c2993..d48a8e9 100755 --- a/util/release/genrelnotes +++ b/util/release/genrelnotes @@ -427,8 +427,8 @@ git log --pretty=%an "${NEW_GIT_VERSION}" 2>/dev/null | \ sort | uniq > "$after_names" && \ grep -Fxv -c -f "$before_names" "$after_names") -NEW_AUTHOR_LIST=$( grep -Fxv -f "$before_names" "$after_names" && \ - rm "$before_names" "$after_names") +NEW_AUTHOR_LIST=$( grep -Fxv -f "$before_names" "$after_names") +rm -f "$before_names" "$after_names" { printf -- "- Total commits: %s\n" "$TOTAL_COMMITS" printf -- "- Total authors: %s\n" \
-
Patrick Georgi (Code Review) -
Stefan Reinauer (Code Review)