Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28640 )
Change subject: mb/clevo/kbl-u: Add Clevo N130WU/N131WU ......................................................................
Patch Set 117:
(5 comments)
https://review.coreboot.org/c/coreboot/+/28640/114/src/mainboard/clevo/kbl-u... File src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/28640/114/src/mainboard/clevo/kbl-u... PS114, Line 15: 3
There's an enum for this.
Done
https://review.coreboot.org/c/coreboot/+/28640/114/src/mainboard/clevo/kbl-u... PS114, Line 19: register "pirqa_routing" = "PCH_IRQ11" : register "pirqb_routing" = "PCH_IRQ10" : register "pirqc_routing" = "PCH_IRQ11" : register "pirqd_routing" = "PCH_IRQ11" : register "pirqe_routing" = "PCH_IRQ11" : register "pirqf_routing" = "PCH_IRQ11" : register "pirqg_routing" = "PCH_IRQ11" : register "pirqh_routing" = "PCH_IRQ11"
Drop this
Done
https://review.coreboot.org/c/coreboot/+/28640/114/src/mainboard/clevo/kbl-u... PS114, Line 160: 0
There's an enum for this
Done
https://review.coreboot.org/c/coreboot/+/28640/114/src/mainboard/clevo/kbl-u... PS114, Line 162: register "SataPortsEnable[1]" = "0"
This should be enabled
Why? According to schematics this one is not available.
https://review.coreboot.org/c/coreboot/+/28640/114/src/mainboard/clevo/kbl-u... PS114, Line 164: register "SataPortsDevSlp[0]" = "0" : register "SataPortsDevSlp[2]" = "0"
Drop this
Just dropped the first one, the latter is supported.