Change in coreboot[master]: drivers/i2c/at24rf08c: Log number of failed writes

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38393 )

Change subject: drivers/i2c/at24rf08c: Log number of failed writes
......................................................................

drivers/i2c/at24rf08c: Log number of failed writes

Change-Id: I1f786043557b11824d4efbde0689d1feb73de6e1
Signed-off-by: Paul Menzel 
---
M src/drivers/i2c/at24rf08c/at24rf08c.c
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/38393/1

diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c
index 11a6fd2..50501ba 100644
--- a/src/drivers/i2c/at24rf08c/at24rf08c.c
+++ b/src/drivers/i2c/at24rf08c/at24rf08c.c
@@ -35,8 +35,10 @@
    	/* After a register write AT24RF08C sometimes stops responding.
    	   Retry several times in case of failure. */
    	for (j = 0; j < 100; j++)
-			if (smbus_write_byte(dev, i, 0x0f) >= 0)
+			if (smbus_write_byte(dev, i, 0x0f) >= 0) {
+				printk(BIOS_DEBUG, "j = %d", j);
    			break;
+			}
    }

printk(BIOS_DEBUG, "init EEPROM done\n");

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38393 )

Change subject: drivers/i2c/at24rf08c: Log number of failed writes
......................................................................

Patch Set 1:

Testing this on the Lenovo T60, all values were zero. The method took 22 ms.

[XS] Change in coreboot[master]: drivers/i2c/at24rf08c: Log number of failed writes

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38393?usp=email )

Change subject: drivers/i2c/at24rf08c: Log number of failed writes
......................................................................

Abandoned