Attention is currently required from: Nico Huber, Krishna Prabhakaran, Furquan Shaikh, Maulik V Vaghela, Selma Bensaid, Subrata Banik, Meera Ravindranath, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 )
Change subject: drivers/intel/gma: Support IGD Opregion 2.1
......................................................................
Patch Set 14:
(1 comment)
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/52758/comment/e57a9460_3b10ac82
PS13, Line 105: INTEL_GMA_OPREGION_2_0
If we have to keep both 2.0 and 2.1 can we find a way to make 2.1 as the default? I think all future platforms would want to select 2.1, so it is better to keep that as the default.
Hmmm, can we try to not rely on implicit defaults? I'd rather have each platform explicitly select the Opregion version it is meant to be used with.
Yes, I know that what I suggested in https://review.coreboot.org/c/coreboot/+/52758/comment/bd09c08d_c09e941a/ selects 2.0 by default, but it's easy to rework the Kconfig options so that nothing is selected by default. I'd do this in another commit (which would also select 2.0 on ADL), then update ADL to use 2.1 in a third commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52758
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95a9f3df185002a4e38faa910f867ace0b97ac2b
Gerrit-Change-Number: 52758
Gerrit-PatchSet: 14
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna Prabhakaran
krishna.prabhakaran@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Krishna Prabhakaran
krishna.prabhakaran@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 08 Jul 2021 10:37:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Meera Ravindranath
meera.ravindranath@intel.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment