Change in coreboot[master]: [WIP] mb/intel/cannonlake_rvp: Unconditionally select audio drivers
Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41706 )
Change subject: [WIP] mb/intel/cannonlake_rvp: Unconditionally select audio drivers ......................................................................
[WIP] mb/intel/cannonlake_rvp: Unconditionally select audio drivers
Change-Id: Ic9f2e44692b20c2efabc468b10ec531e8b5a3e59 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/intel/cannonlake_rvp/Kconfig 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/41706/1
diff --git a/src/mainboard/intel/cannonlake_rvp/Kconfig b/src/mainboard/intel/cannonlake_rvp/Kconfig index e4885a8..b34079b 100644 --- a/src/mainboard/intel/cannonlake_rvp/Kconfig +++ b/src/mainboard/intel/cannonlake_rvp/Kconfig @@ -10,6 +10,9 @@ select GENERIC_SPD_BIN select DRIVERS_I2C_HID select DRIVERS_I2C_GENERIC + select DRIVERS_I2C_DA7219 + select DRIVERS_I2C_MAX98373 + select DRIVERS_GENERIC_MAX98357A select SOC_INTEL_CANNONLAKE select MAINBOARD_USES_IFD_EC_REGION select INTEL_LPSS_UART_FOR_CONSOLE @@ -42,8 +45,6 @@
config INCLUDE_SND_MAX98357_DA7219_NHLT bool "Include blobs for audio with MAX98357_DA7219" - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_I2C_DA7219 select NHLT_DMIC_4CH_16B select NHLT_DMIC_2CH_16B select NHLT_DA7219 @@ -51,7 +52,6 @@
config INCLUDE_SND_MAX98373_NHLT bool "Include blobs for audio with MAX98373" - select DRIVERS_I2C_MAX98373 select NHLT_DMIC_4CH_16B select NHLT_DMIC_2CH_16B select NHLT_MAX98373
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41706 )
Change subject: [WIP] mb/intel/cannonlake_rvp: Unconditionally select audio drivers ......................................................................
Patch Set 4: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41706
to look at the new patch set (#5).
Change subject: mb/intel/cannonlake_rvp: Unconditionally select audio drivers ......................................................................
mb/intel/cannonlake_rvp: Unconditionally select audio drivers
Change-Id: Ic9f2e44692b20c2efabc468b10ec531e8b5a3e59 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/intel/cannonlake_rvp/Kconfig 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/41706/5
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41706 )
Change subject: mb/intel/cannonlake_rvp: Unconditionally select audio drivers ......................................................................
Patch Set 5: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41706 )
Change subject: mb/intel/cannonlake_rvp: Unconditionally select audio drivers ......................................................................
Patch Set 5: Code-Review+1
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41706 )
Change subject: mb/intel/cannonlake_rvp: Unconditionally select audio drivers ......................................................................
mb/intel/cannonlake_rvp: Unconditionally select audio drivers
Change-Id: Ic9f2e44692b20c2efabc468b10ec531e8b5a3e59 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41706 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/cannonlake_rvp/Kconfig 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/intel/cannonlake_rvp/Kconfig b/src/mainboard/intel/cannonlake_rvp/Kconfig index 4b5a4ef..32c9487 100644 --- a/src/mainboard/intel/cannonlake_rvp/Kconfig +++ b/src/mainboard/intel/cannonlake_rvp/Kconfig @@ -10,6 +10,9 @@ select GENERIC_SPD_BIN select DRIVERS_I2C_HID select DRIVERS_I2C_GENERIC + select DRIVERS_I2C_DA7219 + select DRIVERS_I2C_MAX98373 + select DRIVERS_GENERIC_MAX98357A select SOC_INTEL_CANNONLAKE select MAINBOARD_USES_IFD_EC_REGION select INTEL_LPSS_UART_FOR_CONSOLE @@ -42,8 +45,6 @@
config INCLUDE_SND_MAX98357_DA7219_NHLT bool "Include blobs for audio with MAX98357_DA7219" - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_I2C_DA7219 select NHLT_DMIC_4CH_16B select NHLT_DMIC_2CH_16B select NHLT_DA7219 @@ -51,7 +52,6 @@
config INCLUDE_SND_MAX98373_NHLT bool "Include blobs for audio with MAX98373" - select DRIVERS_I2C_MAX98373 select NHLT_DMIC_4CH_16B select NHLT_DMIC_2CH_16B select NHLT_MAX98373
-
Furquan Shaikh (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)