Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68184 )
Change subject: soc/amd/common/psp_verstage: Pass SRAM buffer to Crypto Engine
......................................................................
Patch Set 10:
(1 comment)
File src/soc/amd/common/psp_verstage/vboot_crypto.c:
https://review.coreboot.org/c/coreboot/+/68184/comment/ca739dff_cadc1757
PS10, Line 98: CONFIG_VBOOT_HASH_BLOCK_SIZE
Hrmm, how large is this? Will this overflow the stack?
My testing indicated it should not. Earlier when we verify the entire FW body, vboot used the same amount of memory from the stack - https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/hea...
It is currently at 36 KB - configured on a per-SoC basis.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68184
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9bc9e786f302e7938969c8093d5405b5a85b711
Gerrit-Change-Number: 68184
Gerrit-PatchSet: 10
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 26 Oct 2022 15:57:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment