Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34350 )
Change subject: Doc/lessons/lesson1: Fix title consistency ......................................................................
Doc/lessons/lesson1: Fix title consistency
Make the title for lesson 1 match the format used for lesson 2 and the lessons index, for consistency purposes.
Change-Id: I133d758ddf4974096cbf9f10ae96c148fc859efc Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Documentation/lessons/lesson1.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/34350/1
diff --git a/Documentation/lessons/lesson1.md b/Documentation/lessons/lesson1.md index 2ca25b3..e535451 100644 --- a/Documentation/lessons/lesson1.md +++ b/Documentation/lessons/lesson1.md @@ -1,4 +1,4 @@ -coreboot lesson 1 - Starting from scratch +coreboot Lesson 1: Starting from scratch =========================================
From a fresh Ubuntu 16.04 or 18.04 install, here are all the steps required for
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34350 )
Change subject: Doc/lessons/lesson1: Fix title consistency ......................................................................
Patch Set 1:
Extremely trivial change
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34350 )
Change subject: Doc/lessons/lesson1: Fix title consistency ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34350 )
Change subject: Doc/lessons/lesson1: Fix title consistency ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34350/1/Documentation/lessons/lesso... File Documentation/lessons/lesson1.md:
https://review.coreboot.org/c/coreboot/+/34350/1/Documentation/lessons/lesso... PS1, Line 2: ========================================= Remove one `=`?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34350 )
Change subject: Doc/lessons/lesson1: Fix title consistency ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34350/1/Documentation/lessons/lesso... File Documentation/lessons/lesson1.md:
https://review.coreboot.org/c/coreboot/+/34350/1/Documentation/lessons/lesso... PS1, Line 2: =========================================
Remove one `=`?
*screams internally*
Hello Patrick Rudolph, Jacob Garber, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34350
to look at the new patch set (#2).
Change subject: Doc/lessons/lesson1: Fix title consistency ......................................................................
Doc/lessons/lesson1: Fix title consistency
Make the title for lesson 1 match the format used for lesson 2 and the lessons index, for consistency purposes.
Change-Id: I133d758ddf4974096cbf9f10ae96c148fc859efc Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Documentation/lessons/lesson1.md 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/34350/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34350 )
Change subject: Doc/lessons/lesson1: Fix title consistency ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34350/1/Documentation/lessons/lesso... File Documentation/lessons/lesson1.md:
https://review.coreboot.org/c/coreboot/+/34350/1/Documentation/lessons/lesso... PS1, Line 2: =========================================
*screams internally*
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34350 )
Change subject: Doc/lessons/lesson1: Fix title consistency ......................................................................
Patch Set 2: Code-Review+2
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34350 )
Change subject: Doc/lessons/lesson1: Fix title consistency ......................................................................
Patch Set 2: Code-Review+1
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34350 )
Change subject: Doc/lessons/lesson1: Fix title consistency ......................................................................
Doc/lessons/lesson1: Fix title consistency
Make the title for lesson 1 match the format used for lesson 2 and the lessons index, for consistency purposes.
Change-Id: I133d758ddf4974096cbf9f10ae96c148fc859efc Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34350 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Jacob Garber jgarber1@ualberta.ca --- M Documentation/lessons/lesson1.md 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Jacob Garber: Looks good to me, but someone else must approve
diff --git a/Documentation/lessons/lesson1.md b/Documentation/lessons/lesson1.md index 2ca25b3..bbb3eb5 100644 --- a/Documentation/lessons/lesson1.md +++ b/Documentation/lessons/lesson1.md @@ -1,5 +1,5 @@ -coreboot lesson 1 - Starting from scratch -========================================= +coreboot Lesson 1: Starting from scratch +========================================
From a fresh Ubuntu 16.04 or 18.04 install, here are all the steps required for a very basic build:
-
Angel Pons (Code Review) -
Jacob Garber (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)