[L] Change in coreboot[main]: mb/hp: Add Pro 3400 - coreboot-gerrit

2 Jan 2025


      Attention is currently required from: Angel Pons.
Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85825/comment/f6e80d36_e3e7e734?usp... :
PS1, Line 25: 			device ref pci_bridge off end
...
I would remove this but then there would be no devices left on this chip so it wouldn't build. […]
I tried finding a workaround for it, but leaving a redundant device in the overlay seems to be the only option.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387
Gerrit-Change-Number: 85825
Gerrit-PatchSet: 2
Gerrit-Owner: Václav Straka venda.straka@gmail.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 02 Jan 2025 15:04:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Václav Straka venda.straka@gmail.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com