Attention is currently required from: Kane Chen, Kapil Porwal, Kun Liu, Stefan Reinauer, Subrata Banik.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79902?usp=email )
Change subject: util/ifdtool: Enable Read Access for SPI device expansion 2 region
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Not blocking this CL, but a couple more things:
* flashrom support should be added for this region. flashrom knows how to handle regions it doesn't have read/write access to, so it shouldn't fail in this way even if read access was disabled. Can you file a bug for this if there isn't one already?
* Do we understand why this region was added? It looks like it's just the unused space between the end of the ME and start of the BIOS. This used to be part of the ME region. Do we know why it was split out into a separate region?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79902?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I18c44aa9a0f890f01a889247da118b69a58936e8
Gerrit-Change-Number: 79902
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Fri, 12 Jan 2024 04:27:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment