Change in ...coreboot[master]: mb/{i945}: Move CHANNEL_XOR_RANDOMIZATION selection to northbridge
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32928
Change subject: mb/{i945}: Move CHANNEL_XOR_RANDOMIZATION selection to northbridge ......................................................................
mb/{i945}: Move CHANNEL_XOR_RANDOMIZATION selection to northbridge
Change-Id: I31e6ed6cb040dcba756cbfd2247d90753d372915 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbook21/Kconfig M src/mainboard/asus/p5gc-mx/Kconfig M src/mainboard/getac/p470/Kconfig M src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig M src/mainboard/ibase/mb899/Kconfig M src/mainboard/intel/d945gclf/Kconfig M src/mainboard/kontron/986lcd-m/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x60/Kconfig M src/mainboard/lenovo/z61t/Kconfig M src/mainboard/roda/rk886ex/Kconfig M src/northbridge/intel/i945/Kconfig 12 files changed, 1 insertion(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/32928/1
diff --git a/src/mainboard/apple/macbook21/Kconfig b/src/mainboard/apple/macbook21/Kconfig index 6535f8f..84c00cf 100644 --- a/src/mainboard/apple/macbook21/Kconfig +++ b/src/mainboard/apple/macbook21/Kconfig @@ -13,7 +13,6 @@ select HAVE_CMOS_DEFAULT select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_2048 - select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15 select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME diff --git a/src/mainboard/asus/p5gc-mx/Kconfig b/src/mainboard/asus/p5gc-mx/Kconfig index 21e57bb..193364a 100644 --- a/src/mainboard/asus/p5gc-mx/Kconfig +++ b/src/mainboard/asus/p5gc-mx/Kconfig @@ -29,7 +29,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 - select CHANNEL_XOR_RANDOMIZATION select MAINBOARD_HAS_NATIVE_VGA_INIT select INTEL_GMA_HAVE_VBT
diff --git a/src/mainboard/getac/p470/Kconfig b/src/mainboard/getac/p470/Kconfig index a5eed1a..9fe40bc 100644 --- a/src/mainboard/getac/p470/Kconfig +++ b/src/mainboard/getac/p470/Kconfig @@ -32,7 +32,6 @@ select HAVE_ACPI_RESUME select UDELAY_LAPIC select BOARD_ROMSIZE_KB_1024 - select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15 select I945_LVDS
diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig b/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig index ea3142a..e9ed54d 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig @@ -29,7 +29,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 - select CHANNEL_XOR_RANDOMIZATION select MAINBOARD_HAS_NATIVE_VGA_INIT select REALTEK_8168_RESET if BOARD_GIGABYTE_GA_945GCM_S2L select INTEL_GMA_HAVE_VBT diff --git a/src/mainboard/ibase/mb899/Kconfig b/src/mainboard/ibase/mb899/Kconfig index 621395d..fcc2e38 100644 --- a/src/mainboard/ibase/mb899/Kconfig +++ b/src/mainboard/ibase/mb899/Kconfig @@ -14,7 +14,6 @@ select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 - select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15
config MAINBOARD_DIR diff --git a/src/mainboard/intel/d945gclf/Kconfig b/src/mainboard/intel/d945gclf/Kconfig index 70fa848..46d82ec 100644 --- a/src/mainboard/intel/d945gclf/Kconfig +++ b/src/mainboard/intel/d945gclf/Kconfig @@ -28,7 +28,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 - select CHANNEL_XOR_RANDOMIZATION select MAINBOARD_HAS_NATIVE_VGA_INIT select INTEL_GMA_HAVE_VBT
diff --git a/src/mainboard/kontron/986lcd-m/Kconfig b/src/mainboard/kontron/986lcd-m/Kconfig index 43bdf14..9dadd55 100644 --- a/src/mainboard/kontron/986lcd-m/Kconfig +++ b/src/mainboard/kontron/986lcd-m/Kconfig @@ -14,7 +14,6 @@ select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 - select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15 select OVERRIDE_CLOCK_DISABLE
diff --git a/src/mainboard/lenovo/t60/Kconfig b/src/mainboard/lenovo/t60/Kconfig index a6a88b3..e4e87c9 100644 --- a/src/mainboard/lenovo/t60/Kconfig +++ b/src/mainboard/lenovo/t60/Kconfig @@ -17,7 +17,6 @@ select INTEL_INT15 select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_2048 - select CHANNEL_XOR_RANDOMIZATION select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select H8_DOCK_EARLY_INIT diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig index 6db7f11..e3aabf3 100644 --- a/src/mainboard/lenovo/x60/Kconfig +++ b/src/mainboard/lenovo/x60/Kconfig @@ -19,7 +19,6 @@ select HAVE_PIRQ_TABLE select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_2048 - select CHANNEL_XOR_RANDOMIZATION select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select USE_OPTION_TABLE diff --git a/src/mainboard/lenovo/z61t/Kconfig b/src/mainboard/lenovo/z61t/Kconfig index a223077..de48d95 100644 --- a/src/mainboard/lenovo/z61t/Kconfig +++ b/src/mainboard/lenovo/z61t/Kconfig @@ -17,7 +17,6 @@ select INTEL_INT15 select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_2048 - select CHANNEL_XOR_RANDOMIZATION select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select H8_DOCK_EARLY_INIT diff --git a/src/mainboard/roda/rk886ex/Kconfig b/src/mainboard/roda/rk886ex/Kconfig index 821a9a1..9e97529 100644 --- a/src/mainboard/roda/rk886ex/Kconfig +++ b/src/mainboard/roda/rk886ex/Kconfig @@ -17,7 +17,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 - select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15
config MAINBOARD_DIR diff --git a/src/northbridge/intel/i945/Kconfig b/src/northbridge/intel/i945/Kconfig index 2c21420..c004224 100644 --- a/src/northbridge/intel/i945/Kconfig +++ b/src/northbridge/intel/i945/Kconfig @@ -32,6 +32,7 @@ select SMM_TSEG select PARALLEL_MP select CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM + select CHANNEL_XOR_RANDOMIZATION
config NORTHBRIDGE_INTEL_SUBTYPE_I945GC def_bool n
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32928 )
Change subject: mb/{i945}: Move CHANNEL_XOR_RANDOMIZATION selection to northbridge ......................................................................
Patch Set 1: Code-Review-1
CHANNEL_XOR_RANDOMIZATION is set for all supported boards based on i945. I don't know if there is some none supported boards that do not support CHANNEL_XOR_RANDOMIZATION.
Hello Alexander Couzens, Patrick Rudolph, Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32928
to look at the new patch set (#2).
Change subject: mb/{i945}: Drop CHANNEL_XOR_RANDOMIZATION selection ......................................................................
mb/{i945}: Drop CHANNEL_XOR_RANDOMIZATION selection
CHANNEL_XOR_RANDOMIZATION is enabled for all supported boards. moreover, regarding the datasheet, for Channel XOR Bit, the value of zero is reserved.
Change-Id: I31e6ed6cb040dcba756cbfd2247d90753d372915 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbook21/Kconfig M src/mainboard/asus/p5gc-mx/Kconfig M src/mainboard/getac/p470/Kconfig M src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig M src/mainboard/ibase/mb899/Kconfig M src/mainboard/intel/d945gclf/Kconfig M src/mainboard/kontron/986lcd-m/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x60/Kconfig M src/mainboard/lenovo/z61t/Kconfig M src/mainboard/roda/rk886ex/Kconfig M src/northbridge/intel/i945/Kconfig M src/northbridge/intel/i945/raminit.c 13 files changed, 2 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/32928/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32928 )
Change subject: mb/{i945}: Drop CHANNEL_XOR_RANDOMIZATION selection ......................................................................
Patch Set 2: Code-Review-1
HAOUAS Elyes has removed a vote on this change.
Change subject: mb/{i945}: Drop CHANNEL_XOR_RANDOMIZATION selection ......................................................................
Removed Code-Review-1 by HAOUAS Elyes ehaouas@noos.fr
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32928 )
Change subject: mb/{i945}: Drop CHANNEL_XOR_RANDOMIZATION selection ......................................................................
Patch Set 2:
Please let me know your thought. Thank you
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32928 )
Change subject: mb/{i945}: Drop CHANNEL_XOR_RANDOMIZATION selection ......................................................................
Patch Set 2:
(2 comments)
There's this specification update for the 915 chipset series that details stuff about Channel XOR Randomization:
https://www.portwell.com.tw/download/ec/datasheet/Mobile%20Intel_915GM_Updat...
It's not the same chipset, but the bit definitions seem to make sense. Please take the comments below with a pinch of salt, as there might be differences.
https://review.coreboot.org/#/c/32928/2/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/32928/2/src/northbridge/intel/i945/raminit.c... PS2, Line 2116: This enables XOR randomization (bit=0), but on the other side of the "else" side there's nothing to disable it (bit=1). Maybe it's missing?
https://review.coreboot.org/#/c/32928/2/src/northbridge/intel/i945/raminit.c... PS2, Line 2117: This selects the host address bit (0 = bit 11, 1 = bit 17) to XOR with the Channel Select bit, if XOR randomization is enabled.
Does it make sense to set this bit on the "else" path, when XOR randomization is disabled?
Hello Alexander Couzens, Patrick Rudolph, Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32928
to look at the new patch set (#3).
Change subject: mb/{i945}: Drop CHANNEL_XOR_RANDOMIZATION selection ......................................................................
mb/{i945}: Drop CHANNEL_XOR_RANDOMIZATION selection
CHANNEL_XOR_RANDOMIZATION is configurable for no reason. Moreover, regarding the datasheet, for Channel XOR Bit, the value of zero is reserved.
Change-Id: I31e6ed6cb040dcba756cbfd2247d90753d372915 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbook21/Kconfig M src/mainboard/asus/p5gc-mx/Kconfig M src/mainboard/getac/p470/Kconfig M src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig M src/mainboard/ibase/mb899/Kconfig M src/mainboard/intel/d945gclf/Kconfig M src/mainboard/kontron/986lcd-m/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x60/Kconfig M src/mainboard/lenovo/z61t/Kconfig M src/mainboard/roda/rk886ex/Kconfig M src/northbridge/intel/i945/Kconfig M src/northbridge/intel/i945/raminit.c 13 files changed, 2 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/32928/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32928 )
Change subject: mb/{i945}: Drop CHANNEL_XOR_RANDOMIZATION selection ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Just remove the clutter, please.
https://review.coreboot.org/#/c/32928/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32928/2//COMMIT_MSG@7 PS2, Line 7: mb/{i945} The code changes are in `nb/intel/i945`.
https://review.coreboot.org/#/c/32928/2/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/32928/2/src/northbridge/intel/i945/raminit.c... PS2, Line 2115: /* enable Channel XOR */ Please drop, the comment above supersedes it.
https://review.coreboot.org/#/c/32928/2/src/northbridge/intel/i945/raminit.c... PS2, Line 2118: #if 0 /* Channel XOR not supported? Bit[9:9] 0: Reserved */ : reg32 &= ~(1 << 9); : #endif Please drop it. I guess it should have set bit10 instead. Bit10 disables it, Bit9 configures which address bit is xor'ed if enabled.
Hello Alexander Couzens, Patrick Rudolph, Arthur Heymans, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32928
to look at the new patch set (#4).
Change subject: nb/i945: Drop CHANNEL_XOR_RANDOMIZATION selection ......................................................................
nb/i945: Drop CHANNEL_XOR_RANDOMIZATION selection
CHANNEL_XOR_RANDOMIZATION is configurable for no reason.
Change-Id: I31e6ed6cb040dcba756cbfd2247d90753d372915 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbook21/Kconfig M src/mainboard/asus/p5gc-mx/Kconfig M src/mainboard/getac/p470/Kconfig M src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig M src/mainboard/ibase/mb899/Kconfig M src/mainboard/intel/d945gclf/Kconfig M src/mainboard/kontron/986lcd-m/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x60/Kconfig M src/mainboard/lenovo/z61t/Kconfig M src/mainboard/roda/rk886ex/Kconfig M src/northbridge/intel/i945/Kconfig M src/northbridge/intel/i945/raminit.c 13 files changed, 0 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/32928/4
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32928 )
Change subject: nb/i945: Drop CHANNEL_XOR_RANDOMIZATION selection ......................................................................
Patch Set 4: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32928 )
Change subject: nb/i945: Drop CHANNEL_XOR_RANDOMIZATION selection ......................................................................
nb/i945: Drop CHANNEL_XOR_RANDOMIZATION selection
CHANNEL_XOR_RANDOMIZATION is configurable for no reason.
Change-Id: I31e6ed6cb040dcba756cbfd2247d90753d372915 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32928 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/apple/macbook21/Kconfig M src/mainboard/asus/p5gc-mx/Kconfig M src/mainboard/getac/p470/Kconfig M src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig M src/mainboard/ibase/mb899/Kconfig M src/mainboard/intel/d945gclf/Kconfig M src/mainboard/kontron/986lcd-m/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x60/Kconfig M src/mainboard/lenovo/z61t/Kconfig M src/mainboard/roda/rk886ex/Kconfig M src/northbridge/intel/i945/Kconfig M src/northbridge/intel/i945/raminit.c 13 files changed, 0 insertions(+), 19 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/apple/macbook21/Kconfig b/src/mainboard/apple/macbook21/Kconfig index 6535f8f..84c00cf 100644 --- a/src/mainboard/apple/macbook21/Kconfig +++ b/src/mainboard/apple/macbook21/Kconfig @@ -13,7 +13,6 @@ select HAVE_CMOS_DEFAULT select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_2048 - select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15 select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME diff --git a/src/mainboard/asus/p5gc-mx/Kconfig b/src/mainboard/asus/p5gc-mx/Kconfig index 21e57bb..193364a 100644 --- a/src/mainboard/asus/p5gc-mx/Kconfig +++ b/src/mainboard/asus/p5gc-mx/Kconfig @@ -29,7 +29,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 - select CHANNEL_XOR_RANDOMIZATION select MAINBOARD_HAS_NATIVE_VGA_INIT select INTEL_GMA_HAVE_VBT
diff --git a/src/mainboard/getac/p470/Kconfig b/src/mainboard/getac/p470/Kconfig index a5eed1a..9fe40bc 100644 --- a/src/mainboard/getac/p470/Kconfig +++ b/src/mainboard/getac/p470/Kconfig @@ -32,7 +32,6 @@ select HAVE_ACPI_RESUME select UDELAY_LAPIC select BOARD_ROMSIZE_KB_1024 - select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15 select I945_LVDS
diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig b/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig index ea3142a..e9ed54d 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig @@ -29,7 +29,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 - select CHANNEL_XOR_RANDOMIZATION select MAINBOARD_HAS_NATIVE_VGA_INIT select REALTEK_8168_RESET if BOARD_GIGABYTE_GA_945GCM_S2L select INTEL_GMA_HAVE_VBT diff --git a/src/mainboard/ibase/mb899/Kconfig b/src/mainboard/ibase/mb899/Kconfig index 621395d..fcc2e38 100644 --- a/src/mainboard/ibase/mb899/Kconfig +++ b/src/mainboard/ibase/mb899/Kconfig @@ -14,7 +14,6 @@ select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 - select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15
config MAINBOARD_DIR diff --git a/src/mainboard/intel/d945gclf/Kconfig b/src/mainboard/intel/d945gclf/Kconfig index 70fa848..46d82ec 100644 --- a/src/mainboard/intel/d945gclf/Kconfig +++ b/src/mainboard/intel/d945gclf/Kconfig @@ -28,7 +28,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 - select CHANNEL_XOR_RANDOMIZATION select MAINBOARD_HAS_NATIVE_VGA_INIT select INTEL_GMA_HAVE_VBT
diff --git a/src/mainboard/kontron/986lcd-m/Kconfig b/src/mainboard/kontron/986lcd-m/Kconfig index 43bdf14..9dadd55 100644 --- a/src/mainboard/kontron/986lcd-m/Kconfig +++ b/src/mainboard/kontron/986lcd-m/Kconfig @@ -14,7 +14,6 @@ select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 - select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15 select OVERRIDE_CLOCK_DISABLE
diff --git a/src/mainboard/lenovo/t60/Kconfig b/src/mainboard/lenovo/t60/Kconfig index a6a88b3..e4e87c9 100644 --- a/src/mainboard/lenovo/t60/Kconfig +++ b/src/mainboard/lenovo/t60/Kconfig @@ -17,7 +17,6 @@ select INTEL_INT15 select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_2048 - select CHANNEL_XOR_RANDOMIZATION select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select H8_DOCK_EARLY_INIT diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig index 6db7f11..e3aabf3 100644 --- a/src/mainboard/lenovo/x60/Kconfig +++ b/src/mainboard/lenovo/x60/Kconfig @@ -19,7 +19,6 @@ select HAVE_PIRQ_TABLE select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_2048 - select CHANNEL_XOR_RANDOMIZATION select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select USE_OPTION_TABLE diff --git a/src/mainboard/lenovo/z61t/Kconfig b/src/mainboard/lenovo/z61t/Kconfig index a223077..de48d95 100644 --- a/src/mainboard/lenovo/z61t/Kconfig +++ b/src/mainboard/lenovo/z61t/Kconfig @@ -17,7 +17,6 @@ select INTEL_INT15 select HAVE_MP_TABLE select BOARD_ROMSIZE_KB_2048 - select CHANNEL_XOR_RANDOMIZATION select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select H8_DOCK_EARLY_INIT diff --git a/src/mainboard/roda/rk886ex/Kconfig b/src/mainboard/roda/rk886ex/Kconfig index 821a9a1..9e97529 100644 --- a/src/mainboard/roda/rk886ex/Kconfig +++ b/src/mainboard/roda/rk886ex/Kconfig @@ -17,7 +17,6 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 - select CHANNEL_XOR_RANDOMIZATION select INTEL_INT15
config MAINBOARD_DIR diff --git a/src/northbridge/intel/i945/Kconfig b/src/northbridge/intel/i945/Kconfig index 2c21420..9325196 100644 --- a/src/northbridge/intel/i945/Kconfig +++ b/src/northbridge/intel/i945/Kconfig @@ -56,10 +56,6 @@ for the LVDS port. A linear framebuffer is only supported for LVDS.
-config CHANNEL_XOR_RANDOMIZATION - bool - default n - config MMCONF_BASE_ADDRESS hex default 0xf0000000 diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index 797ea12..281e7b2 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -2112,12 +2112,8 @@ if (sysinfo->interleaved) {
reg32 = MCHBAR32(DCC); -#if CONFIG(CHANNEL_XOR_RANDOMIZATION) reg32 &= ~(1 << 10); reg32 |= (1 << 9); -#else - reg32 &= ~(1 << 9); -#endif MCHBAR32(DCC) = reg32; }
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)