Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52801 )
Change subject: mb/google/guybrush: Fix S0i3/S3 GPIO configuration ......................................................................
mb/google/guybrush: Fix S0i3/S3 GPIO configuration
Using PAD_WAKE is actually wrong. The wake bits are only supposed to be set when using the GPIO controller to wake the system. Coreboot's current architecture relies on using GPEs to wake the system.
BUG=b:186011392 TEST=Wake system from S0i3 with EC and see GPE 3 increment.
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: If7f9d2c13503c01fb9d834c436dac723f2c3b24c --- M src/mainboard/google/guybrush/variants/baseboard/gpio.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/52801/1
diff --git a/src/mainboard/google/guybrush/variants/baseboard/gpio.c b/src/mainboard/google/guybrush/variants/baseboard/gpio.c index 528ace1..90c9ddf 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/gpio.c +++ b/src/mainboard/google/guybrush/variants/baseboard/gpio.c @@ -17,7 +17,7 @@ /* GSC_SOC_INT_L */ PAD_INT(GPIO_3, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), /* SOC_PEN_DETECT_ODL */ - PAD_WAKE(GPIO_4, PULL_NONE, EDGE_HIGH, S0i3), + PAD_SCI(GPIO_4, PULL_NONE, EDGE_HIGH), /* EN_PP5000_PEN */ PAD_GPO(GPIO_5, LOW), /* EN_PP3300_WLAN */ @@ -27,7 +27,7 @@ /* EN_PWR_WWAN_X */ PAD_GPO(GPIO_8, HIGH), /* SOC_TCHPAD_INT_ODL */ - PAD_INT(GPIO_9, PULL_NONE, EDGE_HIGH, STATUS_DELIVERY), + PAD_SCI(GPIO_9, PULL_NONE, EDGE_HIGH), /* S0A3 */ PAD_NF(GPIO_10, S0A3, PULL_NONE), /* SOC_FP_RST_L */ @@ -38,7 +38,7 @@ /* USB_OC0_L */ PAD_NF(GPIO_16, USB_OC0_L, PULL_NONE), /* SOC_SAR_INT_L */ - PAD_INT(GPIO_17, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), + PAD_SCI(GPIO_17, PULL_NONE, EDGE_LOW), /* WWAN_AUX_RESET_L */ PAD_GPO(GPIO_18, LOW), /* I2C3_SCL */ @@ -46,9 +46,9 @@ /* I2C3_SDA */ PAD_NF(GPIO_20, I2C3_SDA, PULL_NONE), /* SOC_FP_INT_L */ - PAD_INT(GPIO_21, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), + PAD_SCI(GPIO_21, PULL_NONE, EDGE_LOW), /* EC_SOC_WAKE_ODL */ - PAD_WAKE(GPIO_22, PULL_NONE, EDGE_LOW, S0i3), + PAD_SCI(GPIO_22, PULL_NONE, EDGE_LOW), /* AC_PRES */ PAD_NF(GPIO_23, AC_PRES, PULL_UP), /* WWAN_RST_L */