Attention is currently required from: Bao Zheng, Zheng Bao. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54900 )
Change subject: amdfwtool: Print the entry type when dumping the firmwares ......................................................................
Patch Set 2:
(2 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/54900/comment/c6e50c0e_8f1752f8 PS2, Line 653: %x: Maybe %02x or more in order to align of the strings. There are a small number that are only one digit, most are two, and some of the older ones are three.
And would it look better to add a space after the colon?
https://review.coreboot.org/c/coreboot/+/54900/comment/b7be4670_c71d1f7a PS2, Line 664: %x Whatever you decide above, repeat here
-
Marshall Dawson (Code Review)