Attention is currently required from: Subrata Banik.
Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80741?usp=email )
Change subject: drivers/vpd: Add API to read "feature_device_info" VPD
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/vpd/vpd_device_feature.c:
https://review.coreboot.org/c/coreboot/+/80741/comment/41205a44_fabd3601 :
PS1, Line 14: return "";
It is customary to return a NULL pointer for an entry not found.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80741?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d49e2dc49cd2935a9d8023c989869eb9558039d
Gerrit-Change-Number: 80741
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paz Zcharya
pazz@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Gwendal Grignou
gwendal@chromium.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Thu, 29 Feb 2024 16:55:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment