Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86401?usp=email )
(
13 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: drivers/usb/intel_bluetooth: Guard BTRK if no GPIO passed ......................................................................
drivers/usb/intel_bluetooth: Guard BTRK if no GPIO passed
Don't attempt any GPIO operations of there isn't a reset GPIO specified.
Change-Id: I9c97963e61f790f2d9c55d8ec1a384a5779782b4 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86401 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/usb/acpi/intel_bluetooth.c 1 file changed, 12 insertions(+), 10 deletions(-)
Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/drivers/usb/acpi/intel_bluetooth.c b/src/drivers/usb/acpi/intel_bluetooth.c index 151930f..6307dcb 100644 --- a/src/drivers/usb/acpi/intel_bluetooth.c +++ b/src/drivers/usb/acpi/intel_bluetooth.c @@ -328,17 +328,19 @@ */ acpigen_write_method("BTRK", 1); { - acpigen_write_if_lequal_op_int(ARG0_OP, 1); - { - /* De-assert reset */ - acpigen_disable_tx_gpio(reset_gpio); + if (reset_gpio->pin_count) { + acpigen_write_if_lequal_op_int(ARG0_OP, 1); + { + /* De-assert reset */ + acpigen_disable_tx_gpio(reset_gpio); + } + acpigen_write_else(); + { + /* Assert Reset */ + acpigen_enable_tx_gpio(reset_gpio); + } + acpigen_pop_len(); } - acpigen_write_else(); - { - /* Assert Reset */ - acpigen_enable_tx_gpio(reset_gpio); - } - acpigen_pop_len(); } acpigen_pop_len();