Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35135 )
Change subject: arch/x86: remove weak car_stage_entry() symbol ......................................................................
arch/x86: remove weak car_stage_entry() symbol
Many (if not all) platforms have moved to using consistent constructs where a weak car_stage_entry() is no longer necessary to avoid the previous combinations of many different boot flows. Now it's just causing issues so remove it.
Change-Id: I7e7897c0609aac8eef96a08bb789374b2403956d Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/arch/x86/assembly_entry.S 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/35135/1
diff --git a/src/arch/x86/assembly_entry.S b/src/arch/x86/assembly_entry.S index 4ead9ea..0ac59ed 100644 --- a/src/arch/x86/assembly_entry.S +++ b/src/arch/x86/assembly_entry.S @@ -60,9 +60,7 @@ #endif call car_stage_entry
-/* This is here for linking purposes. */ -.weak car_stage_entry -car_stage_entry: + /* Expect to never return. */ 1: jmp 1b
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35135 )
Change subject: arch/x86: remove weak car_stage_entry() symbol ......................................................................
Patch Set 1:
Let's see if things compile.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35135 )
Change subject: arch/x86: remove weak car_stage_entry() symbol ......................................................................
Patch Set 1:
Patch Set 1:
Let's see if things compile.
Thanks, I was wondering what this was about.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35135 )
Change subject: arch/x86: remove weak car_stage_entry() symbol ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Let's see if things compile.
Thanks, I was wondering what this was about.
No space left on device caused the failure. Anyway, we had a lot of compilation combos and boot flows such that it was easier during a transition phase to have a symbol to link with. Now that I think we're largely consistent I think we can try to nuke this. I'll trigger a rebuild later when I hope the storage issue is resolved.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35135 )
Change subject: arch/x86: remove weak car_stage_entry() symbol ......................................................................
Patch Set 1: Code-Review+2
Hello Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35135
to look at the new patch set (#2).
Change subject: arch/x86: remove weak car_stage_entry() symbol ......................................................................
arch/x86: remove weak car_stage_entry() symbol
Many (if not all) platforms have moved to using consistent boot flow constructs where a weak car_stage_entry() is no longer necessary to avoid the complexity of handling the numerous and different boot flow combinations. The weak symbol is just causing issues so remove it.
Change-Id: I7e7897c0609aac8eef96a08bb789374b2403956d Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/arch/x86/assembly_entry.S 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/35135/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35135 )
Change subject: arch/x86: remove weak car_stage_entry() symbol ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35135 )
Change subject: arch/x86: remove weak car_stage_entry() symbol ......................................................................
arch/x86: remove weak car_stage_entry() symbol
Many (if not all) platforms have moved to using consistent boot flow constructs where a weak car_stage_entry() is no longer necessary to avoid the complexity of handling the numerous and different boot flow combinations. The weak symbol is just causing issues so remove it.
Change-Id: I7e7897c0609aac8eef96a08bb789374b2403956d Signed-off-by: Aaron Durbin adurbin@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/35135 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Subrata Banik subrata.banik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/assembly_entry.S 1 file changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/arch/x86/assembly_entry.S b/src/arch/x86/assembly_entry.S index 4ead9ea..0ac59ed 100644 --- a/src/arch/x86/assembly_entry.S +++ b/src/arch/x86/assembly_entry.S @@ -60,9 +60,7 @@ #endif call car_stage_entry
-/* This is here for linking purposes. */ -.weak car_stage_entry -car_stage_entry: + /* Expect to never return. */ 1: jmp 1b
-
Aaron Durbin (Code Review) -
Kyösti Mälkki (Code Review)
-
Subrata Banik (Code Review)