Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 57:
(47 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/042cfb7e_efc1a42b PS57, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/fcb1ef38_865eeb6b PS57, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/f0c03f7a_29e734bf PS57, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/1eea6090_98465f05 PS57, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/90008a5c_49bbabba PS57, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/3c906876_d763ca75 PS57, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/8cdeda6c_ec1c2139 PS57, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/431483cc_d8e8c753 PS57, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/85d55301_6c6d09c2 PS57, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/ffc81afc_45739a7a PS57, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/ed6f8fff_efa6e5c9 PS57, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/ad176587_cf70dcee PS57, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/e56856f6_11e0aad0 PS57, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/d5458d76_8a6dd748 PS57, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwE820.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/a75aee29_2f7d6711 PS57, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwEc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/4253c064_67fd4237 PS57, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/c64442cf_02041257 PS57, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwIo.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/82d9646b_70bdc518 PS57, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/9d7036e3_d2ec0c40 PS57, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/7741f837_ecf90b53 PS57, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/738226e7_25c5767d PS57, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/da6c11c8_35934dc6 PS57, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/5b75d372_6206669d PS57, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/8e858d90_11b5d7a3 PS57, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/8a73ed1f_5e0d8b11 PS57, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/ba40c8b3_a64dd650 PS57, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/b0761acb_50344dd1 PS57, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/c01c38cc_02e9ecb2 PS57, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/ef50f449_f985d157 PS57, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/46ee8fc8_7dac58fd PS57, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/5d3aa660_1fb7a63d PS57, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/d256f55e_828bb335 PS57, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/0e2b6263_269a4463 PS57, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/991e5b5a_50bc0bd3 PS57, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/f93fdca5_4d6ae20e PS57, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/d0118db3_2dad4746 PS57, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/f75905fe_04d37872 PS57, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/7207b647_106565e1 PS57, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/8c4b172e_fd28cabb PS57, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/7c0843d8_3c25d146 PS57, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/38700e78_ec1efa0c PS57, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/8e140594_d464b7e5 PS57, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/965e4930_7ec66de2 PS57, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/a23646bc_da414b7d PS57, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/93b3bef6_9673edad PS57, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/e04e6eea_4b24bbba PS57, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159866): https://review.coreboot.org/c/coreboot/+/23586/comment/02843871_83e5284f PS57, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
-
build bot (Jenkins) (Code Review)