Evan has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37159 )
Change subject: Fix option handling for makedpfw ......................................................................
Fix option handling for makedpfw
Remove the unsupported "trace" long option and add support for the "output" option.
Change-Id: I41ad3d9b9f24d99e4effd215c184379a164e55bb --- M makedpfw.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/59/37159/1
diff --git a/makedpfw.c b/makedpfw.c index 2b03138..97dfe15 100644 --- a/makedpfw.c +++ b/makedpfw.c @@ -51,7 +51,7 @@ static const struct option longopts[] = { {"debug", 0, 0, 'D'}, {"help", 0, 0, 'h'}, - {"trace", 0, 0, 't'}, + {"output", 1, 0, 'o'}, {"mcu-file", 1, 0, 'm'}, {"mcu-version", 1, 0, 'M'}, {"fpga-file", 1, 0, 'f'},
Evan Lojewski has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37159 )
Change subject: Fix option handling for makedpfw ......................................................................
Patch Set 1:
This is a simple change to fix what looks like a copy paste error from another tool.
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/em100/+/37159
to look at the new patch set (#2).
Change subject: Fix option handling for makedpfw ......................................................................
Fix option handling for makedpfw
Remove the unsupported "trace" long option and add support for the "output" option.
Change-Id: I41ad3d9b9f24d99e4effd215c184379a164e55bb Signed-off-by: Evan Lojewski github@meklort.com --- M makedpfw.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/59/37159/2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37159 )
Change subject: Fix option handling for makedpfw ......................................................................
Patch Set 2: Code-Review+2
Haha, nice. Thanks!
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37159 )
Change subject: Fix option handling for makedpfw ......................................................................
Fix option handling for makedpfw
Remove the unsupported "trace" long option and add support for the "output" option.
Change-Id: I41ad3d9b9f24d99e4effd215c184379a164e55bb Signed-off-by: Evan Lojewski github@meklort.com Reviewed-on: https://review.coreboot.org/c/em100/+/37159 Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M makedpfw.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
diff --git a/makedpfw.c b/makedpfw.c index 2b03138..97dfe15 100644 --- a/makedpfw.c +++ b/makedpfw.c @@ -51,7 +51,7 @@ static const struct option longopts[] = { {"debug", 0, 0, 'D'}, {"help", 0, 0, 'h'}, - {"trace", 0, 0, 't'}, + {"output", 1, 0, 'o'}, {"mcu-file", 1, 0, 'm'}, {"mcu-version", 1, 0, 'M'}, {"fpga-file", 1, 0, 'f'},
-
Evan (Code Review) -
Evan Lojewski (Code Review)
-
Stefan Reinauer (Code Review)