Attention is currently required from: Jérémy Compostella.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85553?usp=email )
Change subject: soc/intel/common: Read core scaling factors at runtime support ......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/acpi.h:
https://review.coreboot.org/c/coreboot/+/85553/comment/91bc945b_259a27de?usp... : PS8, Line 28: enum cb_err soc_read_core_scaling_factors(u16 *performance, u16 *efficient);
unable to locate the implementation of this API ?
soc_read_core_scaling_factors
I believe this should be guarded against `SOC_INTEL_COMMON_BLOCK_RUNTIME_CORE_SCALING_FACTORS` Kconfig and use dummy inline function for all the other cases. In that way, the separation would have been clear.
``` #if CONFIG(SOC_INTEL_COMMON_BLOCK_RUNTIME_CORE_SCALING_FACTORS) enum cb_err soc_read_core_scaling_factors(u16 *performance, u16 *efficient); #else static inline enum cb_err soc_read_core_scaling_factors(u16 *performance, u16 *efficient) { *performance = CONFIG_SOC_INTEL_PERFORMANCE_CORE_SCALE_FACTOR; *efficient = CONFIG_SOC_INTEL_EFFICIENT_CORE_SCALE_FACTOR; } #endif ```