Change in coreboot[master]: amdfwtool: Add a macro to set explicitly second gen for old SOCs - coreboot-gerrit

4 Apr 2022


      Attention is currently required from: Zheng Bao, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63319 )
Change subject: amdfwtool: Add a macro to set explicitly second gen for old SOCs
......................................................................
Patch Set 2:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/63319/comment/34cc58de_145bccf4 
PS1, Line 1808: 	amd_romsig->efs_gen.reserved = 0;
...
i wonder if this should also be moved inside the set_efs_table function and if that should also be s […]
done.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65caa11e835d2ff52bec4b8904057bbced434891
Gerrit-Change-Number: 63319
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 04 Apr 2022 02:48:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment