Change in coreboot[master]: sc7180: Add QUPv3 FW load & config - coreboot-gerrit

11 Mar 2020


      Roja Rani Yarubandi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 )
Change subject: sc7180: Add QUPv3 FW load & config
......................................................................
Patch Set 42:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35499/40/src/soc/qualcomm/sc7180/qu... 
File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/35499/40/src/soc/qualcomm/sc7180/qu... 
PS40, Line 51: 		assert(protocol < SE_PROTOCOL_MAX);
...
There are actually other protocols you defined that are not in this list (i.e. I3C). […]
will do the changes and update patch
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/35499
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d91dd10488931247f81a87b0bdcc598f4bceb31
Gerrit-Change-Number: 35499
Gerrit-PatchSet: 42
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Doug Anderson dianders@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Akash Asthana akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Gerrit-CC: Satya Priya Kakitapalli c_skakit@qualcomm.corp-partner.google.com
Gerrit-CC: Stephen Boyd swboyd@chromium.org
Gerrit-CC: Taniya Das tdas@codeaurora.org
Gerrit-Comment-Date: Wed, 11 Mar 2020 10:16:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment