[S] Change in coreboot[main]: mb/google/nissa/var/craaskov: Remove TOF function - coreboot-gerrit

13 Oct 2023


      Attention is currently required from: Chen-Tsung Hsieh, Derek Huang, Dtrain Hsu, Ian Feng, Kenny Pan, Nick Vaccaro, Shou-Chieh Hsu, Subrata Banik.
Rex Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78147?usp=email )
Change subject: mb/google/nissa/var/craaskov: Remove TOF function
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/craaskov/gpio.c:
https://review.coreboot.org/c/coreboot/+/78147/comment/aed39740_b1a30876 :
PS1, Line 14: 	/* B5  : GPP_B5 ==> NC */
...
Here is disable i2c bus, should we also disable i2c bus in overridetree.cb? […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78147?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ae6a6562d87f8da5f41691a7606a1aa10989443
Gerrit-Change-Number: 78147
Gerrit-PatchSet: 2
Gerrit-Owner: Rex Chou rex_chou@compal.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@google.com
Gerrit-Reviewer: Derek Huang derekhuang@google.com
Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Kenny Pan kennypan@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Attention: Chen-Tsung Hsieh chentsung@google.com
Gerrit-Attention: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Derek Huang derekhuang@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Kenny Pan kennypan@google.com
Gerrit-Attention: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Comment-Date: Fri, 13 Oct 2023 07:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-MessageType: comment