Attention is currently required from: Julius Werner, Kapil Porwal, Karthik Ramasubramanian.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87152?usp=email )
Change subject: {commonlib, lib}: Add timestamp for early chip initialization
......................................................................
Patch Set 5:
(1 comment)
File src/commonlib/include/commonlib/timestamp_serialized.h:
https://review.coreboot.org/c/coreboot/+/87152/comment/47e7b5c2_53c12e78?usp... :
PS5, Line 222: TS_DEVICE_ENUMERATE
This end_id does not exist in the old coreboot. What is the consequence of that?
The old core boot code with TS_DEVICE_ENUMERATE and the new tool would use 0x31 for device enumeration timestamp since 0x30 (TS_DEVICE_INIT_CHIPS) won't be applicable for the old code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87152?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib6860901c6b1528ec5098fc93240c6e65777642b
Gerrit-Change-Number: 87152
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 07 Apr 2025 17:02:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com