Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41752 )
Change subject: mb/asrock/h110m: Remove duplicated PmTimerDisabled ......................................................................
mb/asrock/h110m: Remove duplicated PmTimerDisabled
This option appears twice in the devicetree. Drop one instance.
Change-Id: I2121770688f64542a02c777d4175fe4739ebb28a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/41752/1
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 254eff8..1327a36 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -135,7 +135,6 @@ }"
register "EnableLan" = "0" - register "PmTimerDisabled" = "0"
# USB register "usb2_ports[0]" = "USB2_PORT_MID(OC0)"
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41752 )
Change subject: mb/asrock/h110m: Remove duplicated PmTimerDisabled ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41752 )
Change subject: mb/asrock/h110m: Remove duplicated PmTimerDisabled ......................................................................
mb/asrock/h110m: Remove duplicated PmTimerDisabled
This option appears twice in the devicetree. Drop one instance.
Change-Id: I2121770688f64542a02c777d4175fe4739ebb28a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41752 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 254eff8..1327a36 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -135,7 +135,6 @@ }"
register "EnableLan" = "0" - register "PmTimerDisabled" = "0"
# USB register "usb2_ports[0]" = "USB2_PORT_MID(OC0)"
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41752 )
Change subject: mb/asrock/h110m: Remove duplicated PmTimerDisabled ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4242 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4241 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4240 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4239
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Nico Huber (Code Review)