Paul Menzel has posted comments on this change. ( https://review.coreboot.org/20741 )
Change subject: mb/google/soraka: Camera PMIC runtime power control
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/#/c/20741/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/20741/8//COMMIT_MSG@9
PS8, Line 9: PMIC(tps68470)
Please add a space before the `(`.
https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/acpi/mipi...
File src/mainboard/google/poppy/acpi/mipi_camera.asl:
https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/acpi/mipi...
PS8, Line 32: * Turn on 3V3_VDD. It takes around 1 ms
: * for volatge to settle to 3.3 Volt.
: * Provide additional 2 ms before we
: * enable regulators.
The allowed text width is longer.
https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/acpi/mipi...
PS8, Line 59: * This reset is avoided in S3 & S0ix resume.
Do not reset PMIC in S3 & S0ix resume.
--
To view, visit
https://review.coreboot.org/20741
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23b0c0a887c9eb5d29b89f14aebba273b01228e0
Gerrit-Change-Number: 20741
Gerrit-PatchSet: 8
Gerrit-Owner: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lakshmi G Prasad
lakshmi.g.prasad@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Reviewer: Ricky Liang
jcliang@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tomasz Figa
tfiga@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: rushikesh s kadam
rushikesh.s.kadam@intel.com
Gerrit-Comment-Date: Tue, 22 Aug 2017 10:09:21 +0000
Gerrit-HasComments: Yes