Attention is currently required from: Subrata Banik, Kangheui Won, Reka Norman, Tim Wawrzynczak, Eric Lai.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64091 )
Change subject: mb/google/nissa/var/nivviks: Update pen detect gpio
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64091/comment/2783e75a_e9fe527a
PS2, Line 7: mb/google/nissa/var/nivviks: Update pen detect gpio
Maybe:
Use interrupt with lock for pen detect GPIO
https://review.coreboot.org/c/coreboot/+/64091/comment/9d6f54c3_012b7aef
PS2, Line 9: If use GPIO_DRIVER_LOCK will cause kernel driver can't change to IRQ.
Maybe:
With GPIO_DRIVER_LOCK the Linux kernel <VERSION> can’t change to IRQ.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64091
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f9fdfb2622b4b955da216119e74c6f7d5795d36
Gerrit-Change-Number: 64091
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 06 May 2022 08:04:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment