Change in coreboot[master]: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44637 )
Change subject: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware ......................................................................
mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware
A88XM-E doesn't have any SAS or NVMe controllers and couldn't have a TPM so it makes sense to disable the related SeaBIOS options for this board. This reduces the size of compiled SeaBIOS by 129344-110048=19296 bytes.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ie9760449734499628637e015cacc0541ec0002a2 --- M src/mainboard/asus/a88xm-e/Kconfig A src/mainboard/asus/a88xm-e/config_seabios 2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/44637/1
diff --git a/src/mainboard/asus/a88xm-e/Kconfig b/src/mainboard/asus/a88xm-e/Kconfig index 6874e9e..139f989 100644 --- a/src/mainboard/asus/a88xm-e/Kconfig +++ b/src/mainboard/asus/a88xm-e/Kconfig @@ -56,4 +56,8 @@ bool default n
+config PAYLOAD_CONFIGFILE + string + default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS + endif # BOARD_ASUS_A88XM_E diff --git a/src/mainboard/asus/a88xm-e/config_seabios b/src/mainboard/asus/a88xm-e/config_seabios new file mode 100644 index 0000000..03bf0e8 --- /dev/null +++ b/src/mainboard/asus/a88xm-e/config_seabios @@ -0,0 +1,7 @@ +### +### SeaBIOS custom configuration for ASUS A88XM-E +### +# CONFIG_MEGASAS is not set +# CONFIG_NVME is not set +# CONFIG_TCGBIOS is not set +#
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44637 )
Change subject: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44637/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44637/1//COMMIT_MSG@9 PS1, Line 9: doesn't have any SAS or NVMe controllers The board has PCIe slots, so it would be possible to install a NVMe or SAS controller. SAS cards will often have option ROMs, but NVMe cards (to my knowledge) usually don't, so I'd say NVMe support at least should be retained.
Jonathan Kollasch has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44637 )
Change subject: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware ......................................................................
Patch Set 1:
As you noted with am1i-a, this board has a PCIe slot that could accept SAS or NVMe cards.
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44637 )
Change subject: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware ......................................................................
Abandoned
A88XM-E has a PCIe port where a card with SAS or NVMe controller could be installed.
Mike Banon has restored this change. ( https://review.coreboot.org/c/coreboot/+/44637 )
Change subject: mb/asus/a88xm-e: Disable SeaBIOS options unsupported by hardware ......................................................................
Restored
-
Jonathan Kollasch (Code Review) -
Mike Banon (Code Review)