Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41128 )
Change subject: soc/amd/picasso: fix iomap for ACPI_PM
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/41128/1/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/41128/1/src/soc/amd/picasso/include...
PS1, Line 69: /* HACK for dalboz - doc says 0x14 for GPE0_BLK */
We shouldn't reference a specific design in common code.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41128
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6adf71479c30f5b6751a21edc4bfa311ddbef5ec
Gerrit-Change-Number: 41128
Gerrit-PatchSet: 2
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 07 May 2020 05:22:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment