Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54027 )
Change subject: soc/amd/common/block/pci: Capitalize PCI ACPI names ......................................................................
soc/amd/common/block/pci: Capitalize PCI ACPI names
Lowercase characters are not valid ACPI identifiers.
BUG=b:184766519 TEST=Boot picasso to OS and verify ACPI errors are no longer printed.
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I75aca67f4607e97ced8ac00ac68e51c359aff944 Reviewed-on: https://review.coreboot.org/c/coreboot/+/54027 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Jason Glenesk jason.glenesk@gmail.com --- M src/soc/amd/common/block/pci/pcie_gpp.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Marshall Dawson: Looks good to me, approved Jason Glenesk: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/common/block/pci/pcie_gpp.c b/src/soc/amd/common/block/pci/pcie_gpp.c index 58c7761..a3ac1cf 100644 --- a/src/soc/amd/common/block/pci/pcie_gpp.c +++ b/src/soc/amd/common/block/pci/pcie_gpp.c @@ -22,7 +22,7 @@ return NULL;
name = malloc(ACPI_NAME_BUFFER_SIZE); - snprintf(name, ACPI_NAME_BUFFER_SIZE, "GP%02x", dev->path.pci.devfn); + snprintf(name, ACPI_NAME_BUFFER_SIZE, "GP%02X", dev->path.pci.devfn); name[4] = '\0';
return name;