Change in ...coreboot[master]: src/device/Kconfig: Change default VESA mode from 117h to 118h
Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31595
to review the following change.
Change subject: src/device/Kconfig: Change default VESA mode from 117h to 118h ......................................................................
src/device/Kconfig: Change default VESA mode from 117h to 118h
Change default VESA/native framebuffer mode (needed for bootsplash and graphical framebuffer console) from 117h (1024x768 64k-color (5:6:5)) to 118h (1024x768 16.8M-color (8:8:8)) mode.
This provides console output at Lenovo G505S even if e.g. GRUB is the payload, while not causing any downsides for the other boards.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ia348199bbd430532b1399706dd84490c9680b5f5 --- M src/device/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/31595/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index b90b15f..f0fdce2 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -265,7 +265,7 @@
choice prompt "framebuffer graphics resolution" - default FRAMEBUFFER_VESA_MODE_117 + default FRAMEBUFFER_VESA_MODE_118 help This option sets the resolution used for the coreboot framebuffer (and bootsplash screen). @@ -391,7 +391,7 @@ default 0x119 if FRAMEBUFFER_VESA_MODE_119 default 0x11A if FRAMEBUFFER_VESA_MODE_11A default 0x11B if FRAMEBUFFER_VESA_MODE_11B - default 0x117 if FRAMEBUFFER_VESA_MODE_USER + default 0x118 if FRAMEBUFFER_VESA_MODE_USER
config BOOTSPLASH prompt "Show graphical bootsplash"
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31595 )
Change subject: src/device/Kconfig: Change default VESA mode from 117h to 118h ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31595/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31595/1//COMMIT_MSG@14 PS1, Line 14: while not causing any downsides for the other boards This is an assumption. You could write "while it's unlikely to cause ..."
Hello Mike Banon, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31595
to look at the new patch set (#2).
Change subject: src/device/Kconfig: Change default VESA mode from 117h to 118h ......................................................................
src/device/Kconfig: Change default VESA mode from 117h to 118h
Change default VESA/native framebuffer mode (needed for bootsplash and graphical framebuffer console) from 117h (1024x768 64k-color (5:6:5)) to 118h (1024x768 16.8M-color (8:8:8)) mode.
This provides console output at Lenovo G505S even if e.g. GRUB is the payload, while it is unlikely to cause any downsides for the other boards.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ia348199bbd430532b1399706dd84490c9680b5f5 --- M src/device/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/31595/2
mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31595 )
Change subject: src/device/Kconfig: Change default VESA mode from 117h to 118h ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31595/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31595/1//COMMIT_MSG@14 PS1, Line 14: while not causing any downsides for the other boards
This is an assumption. You could write "while it's unlikely to cause ... […]
Done.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31595 )
Change subject: src/device/Kconfig: Change default VESA mode from 117h to 118h ......................................................................
src/device/Kconfig: Change default VESA mode from 117h to 118h
Change default VESA/native framebuffer mode (needed for bootsplash and graphical framebuffer console) from 117h (1024x768 64k-color (5:6:5)) to 118h (1024x768 16.8M-color (8:8:8)) mode.
This provides console output at Lenovo G505S even if e.g. GRUB is the payload, while it is unlikely to cause any downsides for the other boards.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ia348199bbd430532b1399706dd84490c9680b5f5 Reviewed-on: https://review.coreboot.org/c/31595 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/device/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/device/Kconfig b/src/device/Kconfig index b90b15f..f0fdce2 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -265,7 +265,7 @@
choice prompt "framebuffer graphics resolution" - default FRAMEBUFFER_VESA_MODE_117 + default FRAMEBUFFER_VESA_MODE_118 help This option sets the resolution used for the coreboot framebuffer (and bootsplash screen). @@ -391,7 +391,7 @@ default 0x119 if FRAMEBUFFER_VESA_MODE_119 default 0x11A if FRAMEBUFFER_VESA_MODE_11A default 0x11B if FRAMEBUFFER_VESA_MODE_11B - default 0x117 if FRAMEBUFFER_VESA_MODE_USER + default 0x118 if FRAMEBUFFER_VESA_MODE_USER
config BOOTSPLASH prompt "Show graphical bootsplash"
-
mikeb mikeb (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)