[S] Change in coreboot[master]: soc/mediatek/mt8188: Allow MCUPM to access the secure registers

[Liju-Clr Chen (Code Review)]

Attention is currently required from: Hung-Te Lin.

Liju-Clr Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69088 )

Change subject: soc/mediatek/mt8188: Allow MCUPM to access the secure registers
......................................................................

soc/mediatek/mt8188: Allow MCUPM to access the secure registers

This patch fixes AP hanging issue after boot to login shell. DEVAPC
enables sideband to allow MCUPM to access the secure registers. Also
DEVAPC only allow DOMAIN 0 to access all the non secure registers by
default, remove the DOMAIN 2 setting.

BUG=none
TEST=It works well after boot to login shell.

Change-Id: I67b08c38a31a7eae1bc59543a5148a78b61456d6
Signed-off-by: Liju-Clr Chen 
---
M src/soc/mediatek/mt8188/devapc.c
1 file changed, 18 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/69088/1

diff --git a/src/soc/mediatek/mt8188/devapc.c b/src/soc/mediatek/mt8188/devapc.c
index 260b9ff..a9b7762 100644
--- a/src/soc/mediatek/mt8188/devapc.c
+++ b/src/soc/mediatek/mt8188/devapc.c
@@ -1553,9 +1553,6 @@
    /* Side band */
    SET32_BITFIELDS(getreg(base, MAS_SEC_0), MCUPM_SEC, SECURE_TRANS);

-	/* Master domain */
-	SET32_BITFIELDS(getreg(base, MAS_DOM_0), SCP_SSPM_DOM, DOMAIN_2, MCUPM_DOM, DOMAIN_2);
-
    /* Default APC setting */
    set_infra_ao_apc(base);
 }