Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55892 )
Change subject: device/pci_device.c: Reuse `irq` variable ......................................................................
device/pci_device.c: Reuse `irq` variable
The `irq` variable has the same value as `pIntAtoD[line - 1]`.
Change-Id: Iabf760adbc3014b32cfe6f908dc04c38b71bd980 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/55892 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Werner Zeh werner.zeh@siemens.com --- M src/device/pci_device.c 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved
diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 3634660..63c1dc5 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -1633,11 +1633,10 @@
printk(BIOS_DEBUG, "Assigning IRQ %d to %s\n", irq, dev_path(dev));
- pci_write_config8(dev, PCI_INTERRUPT_LINE, pIntAtoD[line - 1]); + pci_write_config8(dev, PCI_INTERRUPT_LINE, irq);
/* Change to level triggered. */ - i8259_configure_irq_trigger(pIntAtoD[line - 1], - IRQ_LEVEL_TRIGGERED); + i8259_configure_irq_trigger(irq, IRQ_LEVEL_TRIGGERED); } }