Change in coreboot[master]: mb/intel/emeraldlake2: Revise early init

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36893 )

Change subject: mb/intel/emeraldlake2: Revise early init
......................................................................

mb/intel/emeraldlake2: Revise early init

Move UART initialization to bootblock_mainboard_early_init() and don't
override the generic LPC decode settings.

Change-Id: Icdab36ae0324175d3d51a050784b94a53d4b3b7c
Signed-off-by: Nico Huber 
---
M src/mainboard/intel/emeraldlake2/early_init.c
1 file changed, 2 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/36893/1

diff --git a/src/mainboard/intel/emeraldlake2/early_init.c b/src/mainboard/intel/emeraldlake2/early_init.c
index 94a4655..7aabf7c 100644
--- a/src/mainboard/intel/emeraldlake2/early_init.c
+++ b/src/mainboard/intel/emeraldlake2/early_init.c
@@ -29,26 +29,13 @@

#define SIO_PORT 0x164e

-void mainboard_pch_lpc_setup(void)
-{
-	pci_devfn_t dev = PCH_LPC_DEV;
-
-	/* Enable SuperIO + PS/2 Keyboard/Mouse */
-	u16 lpc_config = CNF1_LPC_EN | CNF2_LPC_EN | KBC_LPC_EN;
-	pci_write_config16(dev, LPC_EN, lpc_config);
-
-	/* Enable COM1 */
-	if (sio1007_enable_uart_at(SIO_PORT)) {
-		pci_write_config16(dev, LPC_EN,
-				   lpc_config | COMA_LPC_EN);
-	}
-}
-
 void bootblock_mainboard_early_init(void)
 {
    const u16 port = SIO_PORT;
    const u16 runtime_port = 0x180;

+	sio1007_enable_uart_at(port);
+
    /* Turn on configuration mode. */
    outb(0x55, port);

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36893 )

Change subject: mb/intel/emeraldlake2: Revise early init
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36893 )

Change subject: mb/intel/emeraldlake2: Revise early init
......................................................................

mb/intel/emeraldlake2: Revise early init

Move UART initialization to bootblock_mainboard_early_init() and don't
override the generic LPC decode settings.

Change-Id: Icdab36ae0324175d3d51a050784b94a53d4b3b7c
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36893
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
---
M src/mainboard/intel/emeraldlake2/early_init.c
1 file changed, 2 insertions(+), 15 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved

diff --git a/src/mainboard/intel/emeraldlake2/early_init.c b/src/mainboard/intel/emeraldlake2/early_init.c
index 94a4655..7aabf7c 100644
--- a/src/mainboard/intel/emeraldlake2/early_init.c
+++ b/src/mainboard/intel/emeraldlake2/early_init.c
@@ -29,26 +29,13 @@

#define SIO_PORT 0x164e

-void mainboard_pch_lpc_setup(void)
-{
-	pci_devfn_t dev = PCH_LPC_DEV;
-
-	/* Enable SuperIO + PS/2 Keyboard/Mouse */
-	u16 lpc_config = CNF1_LPC_EN | CNF2_LPC_EN | KBC_LPC_EN;
-	pci_write_config16(dev, LPC_EN, lpc_config);
-
-	/* Enable COM1 */
-	if (sio1007_enable_uart_at(SIO_PORT)) {
-		pci_write_config16(dev, LPC_EN,
-				   lpc_config | COMA_LPC_EN);
-	}
-}
-
 void bootblock_mainboard_early_init(void)
 {
    const u16 port = SIO_PORT;
    const u16 runtime_port = 0x180;

+	sio1007_enable_uart_at(port);
+
    /* Turn on configuration mode. */
    outb(0x55, port);