[M] Change in coreboot[main]: southbridge/intel: Use azalia_audio_init() instead of duplicating code - coreboot-gerrit

19 Jul 2024


      Attention is currently required from: Nicholas Sudsgaard, Nico Huber.
Paul Menzel has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/83504?usp=email )
Change subject: southbridge/intel: Use azalia_audio_init() instead of duplicating code
......................................................................
Patch Set 1:
(1 comment)
File src/southbridge/intel/i82801gx/azalia.c:
https://review.coreboot.org/c/coreboot/+/83504/comment/f7bf42ba_cf269fe9?usp... :
PS1, Line 27: 0x0f
...
Not sure why these only use the first 4 bits as the codec mask (the specification uses 15 bits).
Just mention the difference in the commit message?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83504?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie174ba29c115e3a3419362602d3e3175c9a03708
Gerrit-Change-Number: 83504
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com
Gerrit-Comment-Date: Fri, 19 Jul 2024 06:23:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com