Change in coreboot[master]: soc/intel/skylake: Added irq 11 to the LNK* _PRS

[Wim Vervoorn (Code Review)]

Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37690 )

Change subject: soc/intel/skylake: Added irq 11 to the LNK* _PRS
......................................................................

soc/intel/skylake: Added irq 11 to the LNK* _PRS

The _PRS for the LNK* items don't contain irq 11. So this is not
supposed to be used.

Added irq 11 to the list as there is no reason not to allow this.

BUG=N/A
TEST=tested on facebook monolith

Change-Id: I634d0ea8506a5e93359c652f74131231f5c13b02
Signed-off-by: Wim Vervoorn 
---
M src/soc/intel/skylake/acpi/irqlinks.asl
1 file changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/37690/1

diff --git a/src/soc/intel/skylake/acpi/irqlinks.asl b/src/soc/intel/skylake/acpi/irqlinks.asl
index 1dd50ba..b83c1cb 100644
--- a/src/soc/intel/skylake/acpi/irqlinks.asl
+++ b/src/soc/intel/skylake/acpi/irqlinks.asl
@@ -51,7 +51,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -100,7 +100,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -149,7 +149,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -198,7 +198,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -247,7 +247,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -296,7 +296,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -345,7 +345,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -394,7 +394,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37690 )

Change subject: soc/intel/skylake: Added irq 11 to the LNK* _PRS
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37690/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37690/2//COMMIT_MSG@7 
PS2, Line 7: soc/intel/skylake: Added irq 11 to the LNK* _PRS
'Add'

[Wim Vervoorn (Code Review)]

Hello Patrick Rudolph, Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37690

to look at the new patch set (#3).

Change subject: soc/intel/skylake: Added irq 11 to the LNK* _PRS
......................................................................

soc/intel/skylake: Added irq 11 to the LNK* _PRS

The _PRS for the LNK* items don't contain irq 11. So this is not
supposed to be used.

Add irq 11 to the list as there is no reason not to allow this.

BUG=N/A
TEST=tested on facebook monolith

Change-Id: I634d0ea8506a5e93359c652f74131231f5c13b02
Signed-off-by: Wim Vervoorn 
---
M src/soc/intel/skylake/acpi/irqlinks.asl
1 file changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/37690/3

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37690 )

Change subject: soc/intel/skylake: Added irq 11 to the LNK* _PRS
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37690/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37690/2//COMMIT_MSG@7 
PS2, Line 7: soc/intel/skylake: Added irq 11 to the LNK* _PRS
> 'Add'

Done

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37690 )

Change subject: soc/intel/skylake: Added irq 11 to the LNK* _PRS
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/37690/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37690/3//COMMIT_MSG@7 
PS3, Line 7: Added
Add

Change in coreboot[master]: soc/intel/skylake: Add irq 11 to the LNK* _PRS

[Wim Vervoorn (Code Review)]

Hello Patrick Rudolph, Frans Hendriks, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37690

to look at the new patch set (#4).

Change subject: soc/intel/skylake: Add irq 11 to the LNK* _PRS
......................................................................

soc/intel/skylake: Add irq 11 to the LNK* _PRS

The _PRS for the LNK* items don't contain irq 11. So this is not
supposed to be used.

Add irq 11 to the list as there is no reason not to allow this.

BUG=N/A
TEST=tested on facebook monolith

Change-Id: I634d0ea8506a5e93359c652f74131231f5c13b02
Signed-off-by: Wim Vervoorn 
---
M src/soc/intel/skylake/acpi/irqlinks.asl
1 file changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/37690/4

Change in coreboot[master]: soc/intel/skylake: Add irq 11 to the LNK* _PRS

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37690 )

Change subject: soc/intel/skylake: Add irq 11 to the LNK* _PRS
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37690/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37690/3//COMMIT_MSG@7 
PS3, Line 7: Added
> Add

Done

Change in coreboot[master]: soc/intel/skylake: Add irq 11 to the LNK* _PRS

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37690 )

Change subject: soc/intel/skylake: Add irq 11 to the LNK* _PRS
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: soc/intel/skylake: Add irq 11 to the LNK* _PRS

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37690 )

Change subject: soc/intel/skylake: Add irq 11 to the LNK* _PRS
......................................................................

soc/intel/skylake: Add irq 11 to the LNK* _PRS

The _PRS for the LNK* items don't contain irq 11. So this is not
supposed to be used.

Add irq 11 to the list as there is no reason not to allow this.

BUG=N/A
TEST=tested on facebook monolith

Change-Id: I634d0ea8506a5e93359c652f74131231f5c13b02
Signed-off-by: Wim Vervoorn 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37690
Reviewed-by: Frans Hendriks 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/skylake/acpi/irqlinks.asl
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Frans Hendriks: Looks good to me, approved

diff --git a/src/soc/intel/skylake/acpi/irqlinks.asl b/src/soc/intel/skylake/acpi/irqlinks.asl
index 1dd50ba..b83c1cb 100644
--- a/src/soc/intel/skylake/acpi/irqlinks.asl
+++ b/src/soc/intel/skylake/acpi/irqlinks.asl
@@ -51,7 +51,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -100,7 +100,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -149,7 +149,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -198,7 +198,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -247,7 +247,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -296,7 +296,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -345,7 +345,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)
@@ -394,7 +394,7 @@
    Name (_PRS, ResourceTemplate ()
    {
    	IRQ (Level, ActiveLow, Shared)
-			{ 3, 4, 5, 6, 10, 12, 14, 15 }
+			{ 3, 4, 5, 6, 10, 11, 12, 14, 15 }
    })

Method (_CRS, 0, Serialized)