Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61587 )
Change subject: soc/intel/common: Remove GPIO PAD lock config override from mainboard ......................................................................
soc/intel/common: Remove GPIO PAD lock config override from mainboard
This patch removes mainboard capability to override GPIO PAD lock configuration using `mb_gpio_lock_config` override function as the variant GPIO pad configuration table is now capable of locking GPIO PADs.
BUG=b:208827718 TEST=Able to built and boot brya.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I6769f51afaf79b007d4f199bccc532d6b1c4d435 --- M src/soc/intel/common/block/include/intelblocks/gpio.h M src/soc/intel/common/block/smm/smihandler.c 2 files changed, 0 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/61587/1
diff --git a/src/soc/intel/common/block/include/intelblocks/gpio.h b/src/soc/intel/common/block/include/intelblocks/gpio.h index b37dd12..d5cc8fe 100644 --- a/src/soc/intel/common/block/include/intelblocks/gpio.h +++ b/src/soc/intel/common/block/include/intelblocks/gpio.h @@ -260,12 +260,6 @@ const struct gpio_lock_config *soc_gpio_lock_config(size_t *num);
/* - * Returns an array of gpio_lock_config entries that the mainboard - * deems security risks that should be locked down. - */ -const struct gpio_lock_config *mb_gpio_lock_config(size_t *num); - -/* * Returns the pmc_gpe to gpio_gpe mapping table * */ diff --git a/src/soc/intel/common/block/smm/smihandler.c b/src/soc/intel/common/block/smm/smihandler.c index 32de2f6..8d20d55 100644 --- a/src/soc/intel/common/block/smm/smihandler.c +++ b/src/soc/intel/common/block/smm/smihandler.c @@ -317,32 +317,18 @@ return NULL; }
-__weak const struct gpio_lock_config *mb_gpio_lock_config(size_t *num) -{ - *num = 0; - return NULL; -} - static void soc_lock_gpios(void) { const struct gpio_lock_config *soc_gpios; const struct gpio_lock_config *mb_gpios; size_t soc_gpio_num; - size_t mb_gpio_num;
/* get list of gpios from SoC */ soc_gpios = soc_gpio_lock_config(&soc_gpio_num);
- /* get list of gpios from mainboard */ - mb_gpios = mb_gpio_lock_config(&mb_gpio_num); - /* Lock any soc requested gpios */ if (soc_gpio_num) gpio_lock_pads(soc_gpios, soc_gpio_num); - - /* Lock any mainboard requested gpios */ - if (mb_gpio_num) - gpio_lock_pads(mb_gpios, mb_gpio_num); }
static void finalize(void)