Change in coreboot[master]: drivers/gfx: Add generic graphics with SSDT generator - coreboot-gerrit

14 Oct 2019

Mathew King has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36041 )
Change subject: drivers/gfx: Add generic graphics with SSDT generator
......................................................................
drivers/gfx: Add generic graphics with SSDT generator
This change adds a generic graphics driver that can be added to a
devicetree which populates graphics related ACPI table. It will write
the _DOD method (Enumerate All Devices Attached to the Display Adapter)
and a device object for each device defined. The device may optionally
have a connected privacy screen which can be controlled with a _DSM.
Example:
chip drivers/generic/gfx
  register "device_count" = "1"
  register "device[0].name" = ""LCD""
  register "device[0].addr" = "0x0400"
  register "device[0].privacy.enabled" = "1"
  register "device[0].privacy.detect_function" = ""\_SB.PCI0.PVSC.GPVD""
  register "device[0].privacy.status_function" = ""\_SB.PCI0.PVSC.GPVX""
  register "device[0].privacy.enable_function" = ""\_SB.PCI0.PVSC.EPVX""
  register "device[0].privacy.disable_function" = ""\_SB.PCI0.LPCB.EC0.DPVX""
  device generic 0 on end
end
ASL
Scope (_SB.PCI0.GFX0)
{
    Method (_DOD, 0, NotSerialized)  // _DOD: Display Output Devices
    {
        Return (Package (0x01)
        {
            0x00000400
        })
    }
Device (LCD)
    {
        Name (_HID, "GOOG0010")  // _HID: Hardware ID
        Name (_UID, One)  // _UID: Unique ID
        Name (_ADR, 0x0400)  // _ADR: Address
        Name (_STA, 0x0F)  // _STA: Status
        Method (_DSM, 4, Serialized)  // _DSM: Device-Specific Method
        {
            ToBuffer (Arg0, Local0)
            If ((Local0 == ToUUID ("c7033113-8720-4ceb-9090-9d52b3e52d73")))
            {
                ToInteger (Arg2, Local1)
                If ((Local1 == Zero))
                {
                    Local2 = _SB.PCI0.PVSC.GPVD ()
                    If ((Local2 == One))
                    {
                        Return (Buffer (One)
                        {
                                0x0F
                        })
                    }
                }
If ((Local1 == One))
                {
                    ToBuffer (_SB.PCI0.PVSC.GPVX (), Local2)
                    Return (Local2)
                }
If ((Local1 == 0x02))
                {
                    _SB.PCI0.PVSC.EPVX ()
                }
If ((Local1 == 0x03))
                {
                    _SB.PCI0.PVSC.DPVX ()
                }
Return (Buffer (One)
                {
                        0x00
                })
            }
Return (Buffer (One)
            {
                    0x00
            })
        }
    }
}
BUG=b:142237145
TEST=Added gfx to devicetree on sarien_cml and correct ASL in SSDT
Change-Id: Ida520dd7aad81ee7c1e5f2d0d3f5cc1a766d78a0
Signed-off-by: Mathew King mathewk@chromium.org
---
A src/drivers/generic/gfx/Kconfig
A src/drivers/generic/gfx/Makefile.inc
A src/drivers/generic/gfx/chip.h
A src/drivers/generic/gfx/gfx.c
4 files changed, 174 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/36041/1

diff --git a/src/drivers/generic/gfx/Kconfig b/src/drivers/generic/gfx/Kconfig
new file mode 100644
index 0000000..f59275a
--- /dev/null
+++ b/src/drivers/generic/gfx/Kconfig
@@ -0,0 +1,4 @@
+config DRIVERS_GENERIC_GFX
+	bool
+	default n
+	depends on HAVE_ACPI_TABLES
\ No newline at end of file
diff --git a/src/drivers/generic/gfx/Makefile.inc b/src/drivers/generic/gfx/Makefile.inc
new file mode 100644
index 0000000..c31986b
--- /dev/null
+++ b/src/drivers/generic/gfx/Makefile.inc
@@ -0,0 +1 @@
+ramstage-$(CONFIG_DRIVERS_GENERIC_GFX) += gfx.c
diff --git a/src/drivers/generic/gfx/chip.h b/src/drivers/generic/gfx/chip.h
new file mode 100644
index 0000000..1d8f909
--- /dev/null
+++ b/src/drivers/generic/gfx/chip.h
@@ -0,0 +1,41 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2019 Google LLC
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __DRIVERS_GENERIC_GFX_CHIP_H__
+#define __DRIVERS_GENERIC_GFX_CHIP_H__
+
+struct drivers_generic_gfx_privacy_screen_config
+{
+	int enabled;
+	const char *detect_function;
+	const char *status_function;
+	const char *enable_function;
+	const char *disable_function;
+};
+
+struct drivers_generic_gfx_device_config
+{
+	const char *name;
+	int addr;
+	struct drivers_generic_gfx_privacy_screen_config privacy;
+};
+
+
+struct drivers_generic_gfx_config {
+	int device_count;
+	struct drivers_generic_gfx_device_config device[5];
+};
+
+#endif /* __DRIVERS_GENERIC_GFX_CHIP_H__ */
diff --git a/src/drivers/generic/gfx/gfx.c b/src/drivers/generic/gfx/gfx.c
new file mode 100644
index 0000000..40fc871
--- /dev/null
+++ b/src/drivers/generic/gfx/gfx.c
@@ -0,0 +1,128 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2019 Google LLC
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <arch/acpigen.h>
+#include <device/device.h>
+#include <stdint.h>
+#include <string.h>
+#include "chip.h"
+#include <console/console.h>
+#include <device/pci.h>
+#include <device/pci_ids.h>
+
+#define ACPI_DSM_PRIVACY_SCREEN_UUID	"C7033113-8720-4CEB-9090-9D52B3E52D73"
+
+static void privacy_screen_detect_cb(void *arg)
+{
+	struct drivers_generic_gfx_privacy_screen_config *config = arg;
+
+	acpigen_write_store();
+	acpigen_emit_namestring(config->detect_function);
+	acpigen_emit_byte(LOCAL2_OP);
+	acpigen_write_if_lequal_op_int(LOCAL2_OP, 1);
+	acpigen_write_return_singleton_buffer(0xF);
+	acpigen_pop_len();
+}
+static void privacy_screen_get_status_cb(void *arg)
+{
+	struct drivers_generic_gfx_privacy_screen_config *config = arg;
+
+	acpigen_emit_byte(TO_BUFFER_OP);
+	acpigen_emit_namestring(config->status_function);
+	acpigen_emit_byte(LOCAL2_OP);
+	acpigen_emit_byte(RETURN_OP);
+	acpigen_emit_byte(LOCAL2_OP);
+}
+static void privacy_screen_enable_cb(void *arg)
+{
+	struct drivers_generic_gfx_privacy_screen_config *config = arg;
+
+	acpigen_emit_namestring(config->enable_function);
+}
+static void privacy_screen_disable_cb(void *arg)
+{
+	struct drivers_generic_gfx_privacy_screen_config *config = arg;
+
+	acpigen_emit_namestring(config->disable_function);
+}
+
+static void (*privacy_screen_callbacks[])(void *) = {
+	privacy_screen_detect_cb,
+	privacy_screen_get_status_cb,
+	privacy_screen_enable_cb,
+	privacy_screen_disable_cb,
+};
+
+static void gfx_fill_ssdt_generator(struct device *dev)
+{
+	size_t i;
+	struct drivers_generic_gfx_config *config = dev->chip_info;
+
+	const char *scope = acpi_device_scope(dev);
+
+	acpigen_write_scope(scope);
+
+	/* Method (_DOD, 0) */
+	acpigen_write_method("_DOD", 0);
+	acpigen_emit_byte(RETURN_OP);
+	acpigen_write_package(config->device_count);
+	for (i = 0; i < config->device_count; i++) {
+		acpigen_write_dword (config->device[i].addr);
+	}
+	acpigen_pop_len(); /* End Package. */
+	acpigen_pop_len(); /* End Method. */
+
+	for (i = 0; i < config->device_count; i++) {
+		acpigen_write_device(config->device[i].name);
+
+		acpigen_write_name_integer("_ADR", config->device[i].addr);
+		acpigen_write_name_integer("_STA", 0xF);
+
+		if (config->device[i].privacy.enabled) {
+			acpigen_write_dsm(ACPI_DSM_PRIVACY_SCREEN_UUID,
+				privacy_screen_callbacks,
+				ARRAY_SIZE(privacy_screen_callbacks),
+				&config->device[i].privacy);
+		}
+
+		acpigen_pop_len(); /* Device */
+	}
+	acpigen_pop_len(); /* Scope */
+}
+
+static const char *gfx_acpi_name(const struct device *dev)
+{
+	return "GFX0";
+}
+
+static struct device_operations gfx_ops = {
+	.acpi_name		  = gfx_acpi_name,
+	.acpi_fill_ssdt_generator = gfx_fill_ssdt_generator,
+};
+
+static void gfx_enable(struct device *dev)
+{
+	struct drivers_generic_gfx_config *config = dev->chip_info;
+
+	if (!config)
+		return;
+
+	dev->ops = &gfx_ops;
+}
+
+struct chip_operations drivers_generic_gfx_ops = {
+	CHIP_NAME("Graphics Device")
+	.enable_dev = gfx_enable
+};
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/36041
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida520dd7aad81ee7c1e5f2d0d3f5cc1a766d78a0
Gerrit-Change-Number: 36041
Gerrit-PatchSet: 1
Gerrit-Owner: Mathew King mathewk@chromium.org
Gerrit-MessageType: newchange



    