Attention is currently required from: Maximilian Brune, Philipp Hug.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81031?usp=email )
Change subject: SiFive Unmatched: add support for spi1 x4 mode
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/sifive/hifive-unleashed/media.c:
https://review.coreboot.org/c/coreboot/+/81031/comment/6cb90999_c43243c1 :
PS1, Line 55: die("Wrong configuration of MSEL\n");
did you want to fix the unleashed as well? or was that edit intended on the unmatched?
what was I thinking. Fixed. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81031?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ida7f195eb6e4fc85018ceb83cf317595127c4af5
Gerrit-Change-Number: 81031
Gerrit-PatchSet: 1
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Mon, 04 Mar 2024 18:46:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philipp Hug
philipp@hug.cx
Gerrit-MessageType: comment