Alan Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58692 )
Change subject: mb/google/brya/var/brask: Correct the GPIO config of buzzer
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58692/comment/82c05f20_05f5a758
PS1, Line 12: emerge-brask coreboot depthcharge and verify if the buzzer beeps.
I haven't seen any CLs for buzzer support in depthcharge, did I miss it? Let me know if you need gui […]
Well...Zhuohao has provided us some guidance on IssueTracker and we have been working on that for a while...but I saw you updated some patched on Friday, so we will just follow up your patches to test the function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58692
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84978af152a7117c1f3398a9b7adde161db058dd
Gerrit-Change-Number: 58692
Gerrit-PatchSet: 2
Gerrit-Owner: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 01 Nov 2021 05:19:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment