Attention is currently required from: Nico Huber, Sridhar Siricilla, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61380 )
Change subject: soc/intel/common: Add support to control coreboot and Intel SoC features
......................................................................
Patch Set 14: Code-Review+1
(3 comments)
File src/soc/intel/common/basecode/debug/Kconfig:
https://review.coreboot.org/c/coreboot/+/61380/comment/5f163338_c12b7fa6
PS14, Line 5: Driver to control run time features of Intel SoC & coreboot
can you please give some examples so user know when to select this Kconfig?
File src/soc/intel/common/basecode/debug/debug_feature.c:
https://review.coreboot.org/c/coreboot/+/61380/comment/2704186b_1c36eebe
PS14, Line 24: struct region_device desc_rdev;
suggestion:
static struct pre_mem_ft {
int reserved[64];
} pre_mem_debug;
File src/soc/intel/common/basecode/include/intelbasecode/debug_feature.h:
https://review.coreboot.org/c/coreboot/+/61380/comment/3a778ee7_f84cd1b1
PS14, Line 3: RT
do we need to specify RT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ba40926bd9ad909654f152e48cdd648b28afd62
Gerrit-Change-Number: 61380
Gerrit-PatchSet: 14
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 10 Mar 2022 10:12:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment