Change in ...coreboot[master]: arch/x86/acpigen.c: Add a method to notify all CPU cores

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29895 )

Change subject: arch/x86/acpigen.c: Add a method to notify all CPU cores
......................................................................

Patch Set 2: Code-Review-1

(3 comments)

https://review.coreboot.org/#/c/29895/2/src/arch/x86/acpigen.c 
File src/arch/x86/acpigen.c:

https://review.coreboot.org/#/c/29895/2/src/arch/x86/acpigen.c@375 
PS2, Line 375: 	int coreID;
I know it might have been me who named it like that... but
give it a proper identifier? e.g. core_id?

https://review.coreboot.org/#/c/29895/2/src/arch/x86/acpigen.c@377 
PS2, Line 377: \_PR.
NB. Why the absolute path? At some point we might want to just ensure
that these functions are called in the proper scope. CONFIG_ACPI_CPU_
STRING would have to change too...

https://review.coreboot.org/#/c/29895/2/src/arch/x86/acpigen.c@380 
PS2, Line 380: snprintf(buffer, sizeof(buffer), "\_PR.CP%c%c",
             : 			 '0' + coreID / 10, '0' + coreID % 10);
snprintf(buffer, sizeof(buffer), CONFIG_ACPI_CPU_STRING, coreID);