Attention is currently required from: Keith Hui.
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82480?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: nb/intel/sandybridge: Refactor pei_data building code ......................................................................
nb/intel/sandybridge: Refactor pei_data building code
Incorporate fixed constants and simple data members into struct pei_data as it gets initialized and make more use of existing helpers. Compiler zeroes structs set up this way so the memset() is no longer needed.
Drop northbridge_fill_pei_data() as it gets replaced entirely.
Gut southbridge_fill_pei_data() in preparation for having southbridge code fill in USB-related members.
This is to make the code easier to maintain, and realizes small savings in compiled code size too.
Change-Id: I3140cb99b0106669aa27788641c2895ced048e95 Signed-off-by: Keith Hui buurin@gmail.com --- M src/northbridge/intel/sandybridge/raminit_mrc.c 1 file changed, 36 insertions(+), 40 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/82480/3