Change in coreboot[master]: mb/google/asurada: Implement regulator control for vdd2, vddq and vmddr

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Yidi Lin (Code Review)

14 Oct 2020 14 Oct '20

11:26 a.m.

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement regulator control for vdd2, vddq and vmddr ......................................................................

mb/google/asurada: Implement regulator control for vdd2, vddq and vmddr

These three requlators are controlled via EC.

BUG=b:147789962 BRANCH=none TEST=verified with DRAM driver

Signed-off-by: Yidi Lin yidi.lin@mediatek.com Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/regulator.c 2 files changed, 70 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/46406/1

diff --git a/src/mainboard/google/asurada/Makefile.inc b/src/mainboard/google/asurada/Makefile.inc index 02fb830..d3f8ce6 100644 --- a/src/mainboard/google/asurada/Makefile.inc +++ b/src/mainboard/google/asurada/Makefile.inc @@ -13,6 +13,7 @@ romstage-y += chromeos.c romstage-y += romstage.c romstage-y += sdram_configs.c +romstage-y += regulator.c

ramstage-y += memlayout.ld ramstage-y += boardid.c diff --git a/src/mainboard/google/asurada/regulator.c b/src/mainboard/google/asurada/regulator.c new file mode 100644 index 0000000..514c423 --- /dev/null +++ b/src/mainboard/google/asurada/regulator.c @@ -0,0 +1,69 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <ec/google/chromeec/ec.h> +#include <soc/regulator.h> + +enum mt6360_regulator_id { + MT6360_LDO3, + MT6360_LDO5, + MT6360_LDO6, + MT6360_LDO7, + MT6360_BUCK1, + MT6360_BUCK2, + + MT6360_REGULATOR_COUNT, +}; + +void mainboard_set_vdd2_vol(uint32_t voltage_uv) +{ + uint32_t voltage_mv = voltage_uv / 1000; + + google_chromeec_regulator_set_voltage(MT6360_BUCK1, + voltage_mv, + voltage_mv); +} + +void mainboard_set_vddq_vol(uint32_t voltage_uv) +{ + uint32_t voltage_mv = voltage_uv / 1000; + + google_chromeec_regulator_set_voltage(MT6360_LDO7, + voltage_mv, + voltage_mv); +} + +void mainboard_set_vmddr_vol(uint32_t voltage_uv) +{ + uint32_t voltage_mv = voltage_uv / 1000; + + google_chromeec_regulator_set_voltage(MT6360_LDO6, + voltage_mv, + voltage_mv); +} + +uint32_t mainboard_get_vdd2_vol(void) +{ + uint32_t voltage_mv = 0; + + google_chromeec_regulator_get_voltage(MT6360_BUCK1, &voltage_mv); + + return voltage_mv * 1000; +} + +uint32_t mainboard_get_vddq_vol(void) +{ + uint32_t voltage_mv = 0; + + google_chromeec_regulator_get_voltage(MT6360_LDO7, &voltage_mv); + + return voltage_mv * 1000; +} + +uint32_t mainboard_get_vmddr_vol(void) +{ + uint32_t voltage_mv = 0; + + google_chromeec_regulator_get_voltage(MT6360_LDO6, &voltage_mv); + + return voltage_mv * 1000; +}

Attachments:

attachment.htm (text/html — 7.9 KB)

Show replies by date

Yidi Lin (Code Review)

19 Oct 19 Oct

3:43 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46406

to look at the new patch set (#5).

Change subject: mb/google/asurada: Implement regulator control for vdd2, vddq and vmddr ......................................................................

mb/google/asurada: Implement regulator control for vdd2, vddq and vmddr

These three requlators are controlled via EC.

BUG=b:147789962 BRANCH=none TEST=verified with DRAM driver

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/46406/5

Hung-Te Lin (Code Review)

20 Oct 20 Oct

8:23 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement regulator control for vdd2, vddq and vmddr ......................................................................

Patch Set 5:

(4 comments)

we can unify the mapping in one place.

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 8: MT6360_LDO3 Probably make it clear given you're starting with 3. e.g.,

MT6360_LDO3 = 0,

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 17: static int get_mt6360_regulator_id(enum mtk_regulator regulator) { switch(regulator) { case MTK_REGULATOR_Vdd1: return MT6360_DUMMY; case MTK_REGULATOR_VDD2: return MT6360_BUCK1; ... } printk(BIOS_WARNING...); return -1; }

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 24: MTK_REGULATOR_VDD1: : break; do nothing?

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 26: case MTK_REGULATOR_VDD2: : google_chromeec_regulator_set_voltage(MT6360_BUCK1, : voltage_mv, : voltage_mv); : break; : case MTK_REGULATOR_VDDQ: : google_chromeec_regulator_set_voltage(MT6360_LDO7, : voltage_mv, : voltage_mv); : break; : case MTK_REGULATOR_VMDDR: : google_chromeec_regulator_set_voltage(MT6360_LDO6, : voltage_mv, : voltage_mv); : break; : default: : printk(BIOS_WARNING, "Invalid regualtor ID: %d\n", regulator); : break; : } int id = get_mt6360_regulator_id(regulator);

if (id < 0) return; google_chromeec_regulator_set_voltage(id, voltage_mv, voltage_mv);

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 5 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 20 Oct 2020 08:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

8:47 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement regulator control for vdd2, vddq and vmddr ......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 17:

...

static int get_mt6360_regulator_id(enum mtk_regulator regulator) […]

DRAM regulators are controlled by mt6360(EC side) and MT6359(AP side) on MT8192. Each PMIC has its own regulator ID definition. Such remapping may not easy to apply when using multiple PMICs.

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 24: MTK_REGULATOR_VDD1: : break;

...

do nothing?

controlled by mt6359p

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 5 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 20 Oct 2020 08:47:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

9:07 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement regulator control for vdd2, vddq and vmddr ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 17:

...

DRAM regulators are controlled by mt6360(EC side) and MT6359(AP side) on MT8192. […]

I see, but do we plan to add more? In current implementation it seems that all PMICs are in 6360(=EC) and you left 6359 unimplemented.

Or we can do:

int id;

id = get_mt6360_id(regulator); if (id >= 0) return google_chromeec_regulator_do_something(id, ...);

id = get_mt6359_id(regulator); if (id >= 0) return ap_6359_handler(id, ...);

printk(BIOS_ERROR, "invalid regulator: %d\n", regulator); ...

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 5 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 20 Oct 2020 09:07:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Comment-In-Reply-To: Yidi Lin yidi.lin@mediatek.com Gerrit-MessageType: comment

Yidi Lin (Code Review)

9:43 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement regulator control for vdd2, vddq and vmddr ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 17:

...

I see, but do we plan to add more? In current implementation it seems that all PMICs are in 6360(= […]

6359 implementation depends on CB:45399 which might take longer review process. I planned to summit a separated patch for 6359 implementation.

I can add 6359 implementation to this patch, too.

Thank you for the suggestion on above.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 5 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 20 Oct 2020 09:43:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Comment-In-Reply-To: Yidi Lin yidi.lin@mediatek.com Gerrit-MessageType: comment

Yidi Lin (Code Review)

22 Oct 22 Oct

6:57 a.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46406

to look at the new patch set (#7).

Change subject: mb/google/asurada: Implement board-specific regulator controls. ......................................................................

mb/google/asurada: Implement board-specific regulator controls.

Currently, five regulator controls are implemented for DRAM calibration and DVFS feature.

The regulators for VCORE and VM18 are controlled by MT6359. The reguatlors for VDD1, VDD2 and VMDDR are controlled by MT6360 via EC.

BUG=b:147789962 BRANCH=none TEST=verified with DRAM driver

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/46406/7

Yidi Lin (Code Review)

7:01 a.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement board-specific regulator controls. ......................................................................

Patch Set 7:

(4 comments)

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 8: MT6360_LDO3

...

Probably make it clear given you're starting with 3. e.g., […]

Ack

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 17:

...

6359 implementation depends on CB:45399 which might take longer review process. […]

Ack

https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 24: MTK_REGULATOR_VDD1: : break;

...

controlled by mt6359p

Ack

...

int id = get_mt6360_regulator_id(regulator); […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 7 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 22 Oct 2020 07:01:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Comment-In-Reply-To: Yidi Lin yidi.lin@mediatek.com Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

7:47 a.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement board-specific regulator controls. ......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/46406/7/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/7/src/mainboard/google/asurad... PS7, Line 21: switch(regulator) { space required before the open parenthesis '('

https://review.coreboot.org/c/coreboot/+/46406/7/src/mainboard/google/asurad... PS7, Line 37: switch(regulator) { space required before the open parenthesis '('

https://review.coreboot.org/c/coreboot/+/46406/7/src/mainboard/google/asurad... PS7, Line 79: if (regulator == MTK_REGULATOR_VDD1) { braces {} are not necessary for single statement blocks

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 7 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 22 Oct 2020 07:47:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

7:55 a.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls.

Hello Xi Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Hsin-Hsiung Wang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46406

to look at the new patch set (#8).

Change subject: mb/google/asurada: Implement board-specific regulator controls. ......................................................................

mb/google/asurada: Implement board-specific regulator controls.

Currently, five regulator controls are implemented for DRAM calibration and DVFS feature.

The regulators for VCORE and VM18 are controlled by MT6359. The reguatlors for VDD1, VDD2 and VMDDR are controlled by MT6360 via EC.

BUG=b:147789962 BRANCH=none TEST=verified with DRAM driver

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/46406/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 8 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

23 Oct 23 Oct

7:24 a.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Hello Xi Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Hsin-Hsiung Wang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46406

to look at the new patch set (#9).

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

mb/google/asurada: Implement board-specific regulator controls

Currently, five regulator controls are implemented for DRAM calibration and DVFS feature.

The regulators for VCORE and VM18 are controlled by MT6359. The reguatlors for VDD1, VDD2 and VMDDR are controlled by MT6360 via EC.

BUG=b:147789962 BRANCH=none TEST=verified with DRAM driver

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/46406/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 9 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

11:55 a.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Hello Xi Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Hsin-Hsiung Wang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46406

to look at the new patch set (#10).

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

mb/google/asurada: Implement board-specific regulator controls

Currently, five regulator controls are implemented for DRAM calibration and DVFS feature.

The regulators for VCORE and VM18 are controlled by MT6359. The reguatlors for VDD1, VDD2 and VMDDR are controlled by MT6360 via EC.

BUG=b:147789962 BRANCH=none TEST=verified with DRAM driver

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/46406/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 10 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Yu-Ping Wu (Code Review)

26 Oct 26 Oct

5:55 a.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46406/10/src/mainboard/google/asura... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/10/src/mainboard/google/asura... PS10, Line 72: regualtor regulator

https://review.coreboot.org/c/coreboot/+/46406/10/src/mainboard/google/asura... PS10, Line 95: regualtor regulator

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 10 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Mon, 26 Oct 2020 05:55:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

2:25 p.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Hello Xi Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Hsin-Hsiung Wang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46406

to look at the new patch set (#11).

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

mb/google/asurada: Implement board-specific regulator controls

Currently, five regulator controls are implemented for DRAM calibration and DVFS feature.

The regulators for VCORE and VM18 are controlled by MT6359. The reguatlors for VDD1, VDD2 and VMDDR are controlled by MT6360 via EC.

BUG=b:147789962 BRANCH=none TEST=verified with DRAM driver

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/46406/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 11 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

2:33 p.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46406/10/src/mainboard/google/asura... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/10/src/mainboard/google/asura... PS10, Line 72: regualtor

...

regulator

Ack

https://review.coreboot.org/c/coreboot/+/46406/10/src/mainboard/google/asura... PS10, Line 95: regualtor

...

regulator

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 11 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Mon, 26 Oct 2020 14:33:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

27 Oct 27 Oct

2:22 a.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

Patch Set 11:

(7 comments)

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... File src/mainboard/google/asurada/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 16: romstage-y += regulator.c Please sort these alphabetically (except memlayout.ld).

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 8: mt6360_regulator_id Should we put it in soc/mediatek/mt8192/include/soc/mt6360.h?

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 15: Extra blank line

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 51: underly underlying

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 50: /* Handle the regulator which does not have a regulator ID : * in its underly implementation. */ Please choose one of the following formats:

/* Handle the regulator which does not have a regulator ID in its underly implementation. */

/* * Handle the regulator which does not have a regulator ID * in its underly implementation. */

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 78: underly underlying

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 77: /* Handle the regulator which does not have a regulator ID : * in its underly implementation. */ Same

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 11 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Tue, 27 Oct 2020 02:22:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

12:18 p.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Hello Xi Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Hsin-Hsiung Wang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46406

to look at the new patch set (#12).

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

mb/google/asurada: Implement board-specific regulator controls

Currently, five regulator controls are implemented for DRAM calibration and DVFS feature.

The regulators for VCORE and VM18 are controlled by MT6359. The reguatlors for VDD1, VDD2 and VMDDR are controlled by MT6360 via EC.

BUG=b:147789962 BRANCH=none TEST=verified with DRAM driver

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/46406/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 12 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

12:27 p.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

Patch Set 13:

(7 comments)

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... File src/mainboard/google/asurada/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 16: romstage-y += regulator.c

...

Please sort these alphabetically (except memlayout.ld).

Ack

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 8: mt6360_regulator_id

...

Should we put it in soc/mediatek/mt8192/include/soc/mt6360. […]

Ack

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 15:

...

Extra blank line

Ack

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 51: underly

...

underlying

Ack

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 50: /* Handle the regulator which does not have a regulator ID : * in its underly implementation. */

...

Please choose one of the following formats: […]

Ack

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 78: underly

...

underlying

Ack

https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 77: /* Handle the regulator which does not have a regulator ID : * in its underly implementation. */

...

Same

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 13 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Tue, 27 Oct 2020 12:27:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

28 Oct 28 Oct

3:10 a.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

Patch Set 13:

(2 comments)

Final 2 nits

https://review.coreboot.org/c/coreboot/+/46406/13/src/mainboard/google/asura... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/13/src/mainboard/google/asura... PS13, Line 41: which that

https://review.coreboot.org/c/coreboot/+/46406/13/src/mainboard/google/asura... PS13, Line 70: which that

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 13 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Wed, 28 Oct 2020 03:10:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

12:24 p.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Hello Xi Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Hsin-Hsiung Wang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46406

to look at the new patch set (#14).

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

mb/google/asurada: Implement board-specific regulator controls

Currently, five regulator controls are implemented for DRAM calibration and DVFS feature.

The regulators for VCORE and VM18 are controlled by MT6359. The reguatlors for VDD1, VDD2 and VMDDR are controlled by MT6360 via EC.

BUG=b:147789962 BRANCH=none TEST=verified with DRAM driver

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/46406/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 14 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

12:28 p.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

Patch Set 14:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46406/13/src/mainboard/google/asura... File src/mainboard/google/asurada/regulator.c:

https://review.coreboot.org/c/coreboot/+/46406/13/src/mainboard/google/asura... PS13, Line 41: which

...

that

Ack

https://review.coreboot.org/c/coreboot/+/46406/13/src/mainboard/google/asura... PS13, Line 70: which

...

that

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 14 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Wed, 28 Oct 2020 12:28:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

29 Oct 29 Oct

3:33 a.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

Patch Set 14: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 14 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 29 Oct 2020 03:33:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Yidi Lin (Code Review)

3 Nov 3 Nov

12:49 p.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Hello Xi Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Yu-Ping Wu, Hsin-Hsiung Wang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46406

to look at the new patch set (#17).

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

mb/google/asurada: Implement board-specific regulator controls

Currently, five regulator controls are implemented for DRAM calibration and DVFS feature.

The regulators for VCORE and VM18 are controlled by MT6359. The reguatlors for VDD1, VDD2 and VMDDR are controlled by MT6360 via EC.

BUG=b:147789962 BRANCH=none TEST=verified with DRAM driver

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/46406/17

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 17 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Hung-Te Lin hungte@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Hung-Te Lin (Code Review)

18 Nov 18 Nov

6:13 a.m.

New subject: Change in coreboot[master]: mb/google/asurada: Implement board-specific regulator controls

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46406 )

Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................

mb/google/asurada: Implement board-specific regulator controls

Currently, five regulator controls are implemented for DRAM calibration and DVFS feature.

The regulators for VCORE and VM18 are controlled by MT6359. The reguatlors for VDD1, VDD2 and VMDDR are controlled by MT6360 via EC.

BUG=b:147789962 BRANCH=none TEST=verified with DRAM driver

Signed-off-by: Yidi Lin yidi.lin@mediatek.com Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Reviewed-on: https://review.coreboot.org/c/coreboot/+/46406 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Yu-Ping Wu yupingso@google.com --- M src/mainboard/google/asurada/Makefile.inc A src/mainboard/google/asurada/regulator.c M src/soc/mediatek/common/include/soc/regulator.h A src/soc/mediatek/mt8192/include/soc/mt6360.h 4 files changed, 110 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved

diff --git a/src/mainboard/google/asurada/Makefile.inc b/src/mainboard/google/asurada/Makefile.inc index 02fb830..87582b7 100644 --- a/src/mainboard/google/asurada/Makefile.inc +++ b/src/mainboard/google/asurada/Makefile.inc @@ -11,6 +11,7 @@ romstage-y += memlayout.ld romstage-y += boardid.c romstage-y += chromeos.c +romstage-y += regulator.c romstage-y += romstage.c romstage-y += sdram_configs.c

diff --git a/src/mainboard/google/asurada/regulator.c b/src/mainboard/google/asurada/regulator.c new file mode 100644 index 0000000..b06388d --- /dev/null +++ b/src/mainboard/google/asurada/regulator.c @@ -0,0 +1,92 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <console/console.h> +#include <ec/google/chromeec/ec.h> +#include <soc/mt6359p.h> +#include <soc/mt6360.h> +#include <soc/regulator.h> + +static int get_mt6360_regulator_id(enum mtk_regulator regulator) +{ + switch (regulator) { + case MTK_REGULATOR_VDD2: + return MT6360_BUCK1; + case MTK_REGULATOR_VDDQ: + return MT6360_LDO7; + case MTK_REGULATOR_VMDDR: + return MT6360_LDO6; + default: + break; + } + + return -1; +} + +static int get_mt6359p_regulator_id(enum mtk_regulator regulator) +{ + switch (regulator) { + case MTK_REGULATOR_VCORE: + return MT6359P_GPU11; + default: + break; + } + + return -1; +} + +void mainboard_set_regulator_vol(enum mtk_regulator regulator, + uint32_t voltage_uv) +{ + /* + * Handle the regulator that does not have a regulator ID + * in its underlying implementation. + */ + if (regulator == MTK_REGULATOR_VDD1) { + mt6359p_set_vm18_voltage(voltage_uv); + return; + } + + int id; + + id = get_mt6360_regulator_id(regulator); + if (id >= 0) { + uint32_t voltage_mv = voltage_uv / 1000; + google_chromeec_regulator_set_voltage(id, voltage_mv, voltage_mv); + return; + } + + id = get_mt6359p_regulator_id(regulator); + if (id >= 0) { + mt6359p_buck_set_voltage(id, voltage_uv); + return; + } + + printk(BIOS_WARNING, "Invalid regulator ID: %d\n", regulator); +} + +uint32_t mainboard_get_regulator_vol(enum mtk_regulator regulator) +{ + /* + * Handle the regulator that does not have a regulator ID + * in its underlying implementation. + */ + if (regulator == MTK_REGULATOR_VDD1) + return mt6359p_get_vm18_voltage(); + + int id; + + id = get_mt6360_regulator_id(regulator); + if (id >= 0) { + uint32_t voltage_mv = 0; + google_chromeec_regulator_get_voltage(id, &voltage_mv); + return voltage_mv * 1000; + } + + id = get_mt6359p_regulator_id(regulator); + if (id >= 0) + return mt6359p_buck_get_voltage(id); + + printk(BIOS_WARNING, "Invalid regulator ID: %d\n", regulator); + + return 0; +} diff --git a/src/soc/mediatek/common/include/soc/regulator.h b/src/soc/mediatek/common/include/soc/regulator.h index 258d550..6d9ff4e 100644 --- a/src/soc/mediatek/common/include/soc/regulator.h +++ b/src/soc/mediatek/common/include/soc/regulator.h @@ -10,6 +10,7 @@ MTK_REGULATOR_VDD2, MTK_REGULATOR_VDDQ, MTK_REGULATOR_VMDDR, + MTK_REGULATOR_VCORE, };

void mainboard_set_regulator_vol(enum mtk_regulator regulator, diff --git a/src/soc/mediatek/mt8192/include/soc/mt6360.h b/src/soc/mediatek/mt8192/include/soc/mt6360.h new file mode 100644 index 0000000..a6ee76c --- /dev/null +++ b/src/soc/mediatek/mt8192/include/soc/mt6360.h @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef __SOC_MEDIATEK_MT6360_H__ +#define __SOC_MEDIATEK_MT6360_H__ + +enum mt6360_regulator_id { + MT6360_LDO3 = 0, + MT6360_LDO5, + MT6360_LDO6, + MT6360_LDO7, + MT6360_BUCK1, + MT6360_BUCK2, + MT6360_REGULATOR_COUNT, +}; + +#endif /* __SOC_MEDIATEK_MT6360_H__ */

-- To view, visit https://review.coreboot.org/c/coreboot/+/46406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id06a8196ca4badc51b06759afb07b5664278d13b Gerrit-Change-Number: 46406 Gerrit-PatchSet: 22 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1514

days inactive

1549

days old

coreboot-gerrit@coreboot.org

23 comments

4 participants

tags (0)

participants (4)

build bot (Jenkins) (Code Review)
Hung-Te Lin (Code Review)
Yidi Lin (Code Review)
Yu-Ping Wu (Code Review)