Attention is currently required from: Nico Huber, Sean Rhodes, Matt DeVillier, Paul Menzel, Alexander Couzens.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66380 )
Change subject: ec/lenovo/h8/acpi: Fix wrongly used operator
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66380/comment/ef4f6b69_97f233cf
PS2, Line 9: Commit 37a89d519d4e
Plesae add the summary […]
Done
https://review.coreboot.org/c/coreboot/+/66380/comment/5713e5bf_45e838b8
PS2, Line 12: Built dsdt.aml of lenovo/x230 and it remains the same.
same as? I'd think it should change if the EC ACPI is
Sorry, I rephrased it. What I meant is when this commit is applied after the one introducing the regression. I clarified that.
https://review.coreboot.org/c/coreboot/+/66380/comment/08a8cf14_21aae8a6
PS2, Line 13:
Maybe add a Fixes: tag.
I think the commit message says enough.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa848aafb5480acaac4fabffcf90a3dbf5248e43
Gerrit-Change-Number: 66380
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 05 Oct 2022 21:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment