Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46529 )
Change subject: sb/intel/ibexpeak: Use ARRAY_SIZE macro ......................................................................
sb/intel/ibexpeak: Use ARRAY_SIZE macro
Tested with BUILD_TIMELESS=1, Packard Bell MS2290 remains identical.
Change-Id: I01730e25ee78a74048f0b93faef00ebaee82ba77 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/ibexpeak/lpc.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/46529/1
diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c index 55dcb02..d4f1925 100644 --- a/src/southbridge/intel/ibexpeak/lpc.c +++ b/src/southbridge/intel/ibexpeak/lpc.c @@ -293,7 +293,7 @@ /* 2010: */ 0x00188200, 0x14000016, 0xbc4abcb5, 0x00000000, /* 2020: */ 0xf0c9605b, 0x13683040, 0x04c8f16e, 0x09e90170 }; - for (i = 0; i < sizeof(rcba2010) / sizeof(rcba2010[0]); i++) + for (i = 0; i < ARRAY_SIZE(rcba2010); i++) { RCBA32 (0x2010 + 4 * i) = rcba2010[i]; RCBA32 (0x2010 + 4 * i); @@ -331,7 +331,7 @@ /* 2270 */ 0x00001c01, 0x16000000, 0x00010107, 0x00160000 };
- for (i = 0; i < sizeof(rcba2210) / sizeof(rcba2210[0]); i++) + for (i = 0; i < ARRAY_SIZE(rcba2210); i++) { RCBA32 (0x2210 + 4 * i) = rcba2210[i]; RCBA32 (0x2210 + 4 * i); @@ -344,7 +344,7 @@ /* 2320: */ 0xcccc0cfc, 0x0fbb0fff };
- for (i = 0; i < sizeof(rcba2300) / sizeof(rcba2300[0]); i++) + for (i = 0; i < ARRAY_SIZE(rcba2300); i++) { RCBA32 (0x2300 + 4 * i) = rcba2300[i]; RCBA32 (0x2300 + 4 * i);
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46529 )
Change subject: sb/intel/ibexpeak: Use ARRAY_SIZE macro ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46529 )
Change subject: sb/intel/ibexpeak: Use ARRAY_SIZE macro ......................................................................
sb/intel/ibexpeak: Use ARRAY_SIZE macro
Tested with BUILD_TIMELESS=1, Packard Bell MS2290 remains identical.
Change-Id: I01730e25ee78a74048f0b93faef00ebaee82ba77 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46529 Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/ibexpeak/lpc.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c index 55dcb02..d4f1925 100644 --- a/src/southbridge/intel/ibexpeak/lpc.c +++ b/src/southbridge/intel/ibexpeak/lpc.c @@ -293,7 +293,7 @@ /* 2010: */ 0x00188200, 0x14000016, 0xbc4abcb5, 0x00000000, /* 2020: */ 0xf0c9605b, 0x13683040, 0x04c8f16e, 0x09e90170 }; - for (i = 0; i < sizeof(rcba2010) / sizeof(rcba2010[0]); i++) + for (i = 0; i < ARRAY_SIZE(rcba2010); i++) { RCBA32 (0x2010 + 4 * i) = rcba2010[i]; RCBA32 (0x2010 + 4 * i); @@ -331,7 +331,7 @@ /* 2270 */ 0x00001c01, 0x16000000, 0x00010107, 0x00160000 };
- for (i = 0; i < sizeof(rcba2210) / sizeof(rcba2210[0]); i++) + for (i = 0; i < ARRAY_SIZE(rcba2210); i++) { RCBA32 (0x2210 + 4 * i) = rcba2210[i]; RCBA32 (0x2210 + 4 * i); @@ -344,7 +344,7 @@ /* 2320: */ 0xcccc0cfc, 0x0fbb0fff };
- for (i = 0; i < sizeof(rcba2300) / sizeof(rcba2300[0]); i++) + for (i = 0; i < ARRAY_SIZE(rcba2300); i++) { RCBA32 (0x2300 + 4 * i) = rcba2300[i]; RCBA32 (0x2300 + 4 * i);
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Patrick Georgi (Code Review)