Attention is currently required from: Martin L Roth, Jason Nien, Eric Lai, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73862 )
Change subject: mb/google/skyrim: Hide unused GPP port
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/73862/comment/97b61d6e_3ac89eb6
PS1, Line 110: device ref gpp_bridge_3 hidden end
oh, I see it's the FSP different. […]
the chipset devicetree configures the bridges to the different pcie ports as off, but coreboot will complain about leftover devices if it doesn't see the bridge that's being disabled. when the bridge isn't used for an enabled pcie engine in the port descriptor list, the bridge won't show up at all. setting it to hidden in the mainboard code avoids this warning
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73862
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c1e4c21649610b856469b164ce5b0221f01b7f9
Gerrit-Change-Number: 73862
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 05 Apr 2023 14:51:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment